shared_ptr basic implementation for non array types
How many characters using PHB rules does it take to be able to have access to any PHB spell at the start of an adventuring day?
PTIJ: wiping amalek’s memory?
Is it necessary to separate DC power cables and data cables?
In the quantum hamiltonian, why does kinetic energy turn into an operator while potential doesn't?
How to detect if C code (which needs 'extern C') is compiled in C++
When traveling to Europe from North America, do I need to purchase a different power strip?
How does one describe somebody who is bi-racial?
Counting all the hearts
Motivation for Zeta Function of an Algebraic Variety
Why does liquid water form when we exhale on a mirror?
How is the wildcard * interpreted as a command?
Why the color red for the Republican Party
Should I take out a loan for a friend to invest on my behalf?
How can I ensure my trip to the UK will not have to be cancelled because of Brexit?
Signed and unsigned numbers
weren't playing vs didn't play
Doesn't allowing a user mode program to access kernel space memory and execute the IN and OUT instructions defeat the purpose of having CPU modes?
Rewrite the power sum in terms of convolution
Find longest word in a string: are any of these algorithms good?
Do items de-spawn in Diablo?
NASA's RS-25 Engines shut down time
Why does Captain Marvel assume the people on this planet know this?
Are babies of evil humanoid species inherently evil?
Reversed Sudoku
shared_ptr basic implementation for non array types
$begingroup$
This is an implementation to simulate the basic functionality of c++ shared_ptr.
This doesn't provide features like custom deleter and make_shared().
I would really appreciate any feedback to improve the below code, any other api's that I should be providing etc.
#ifndef SHARED_PTR_H_
#define SHARED_PTR_H_
#include <utility>
namespace kapil {
template <typename T>
class shared_ptr {
private:
T* ptr_; // data pointer
int* ref_count_; // reference count pointer
void decrement_ref_count_and_delete_if_needed() {
if (ref_count_) {
--(*ref_count_);
if (*ref_count_ == 0) {
delete ptr_;
delete ref_count_;
ptr_ = nullptr;
ref_count_ = nullptr;
}
}
}
public:
constexpr shared_ptr() noexcept : ptr_{nullptr}, ref_count_{nullptr} {}
constexpr explicit shared_ptr(T* ptr) { // constructor
ptr_ = ptr;
ref_count_ = new int{1};
}
shared_ptr(const shared_ptr& other) noexcept { // copy constructor
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
if (ref_count_ != nullptr) {
++(*ref_count_);
}
}
shared_ptr(shared_ptr&& other) noexcept { // move constructor
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
other.ptr_ = nullptr;
other.ref_count_ = nullptr;
}
~shared_ptr() noexcept { // destructor
decrement_ref_count_and_delete_if_needed();
}
shared_ptr& operator = (const shared_ptr& other) noexcept { // assignent operator
if (this != &other) {
decrement_ref_count_and_delete_if_needed();
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
if (ref_count_) {
++(*ref_count_);
}
}
return *this;
}
shared_ptr& operator = (shared_ptr&& other) noexcept { // move assignment operator
*this = other;
}
T* get() const noexcept {
return ptr_;
}
void reset() noexcept {
decrement_ref_count_and_delete_if_needed();
}
void reset(T* ptr) {
decrement_ref_count_and_delete_if_needed();
ptr_ = ptr;
if (!ref_count_) {
ref_count_ = new int{1};
}
*ref_count_ = 1;
}
int use_count() const noexcept {
return *ref_count_;
}
void swap (shared_ptr& other) {
std::swap(ptr_, other.ptr_);
std::swap(ref_count_, other.ref_count_);
}
T& operator * () const {
return *ptr_;
}
T* operator -> () const noexcept {
return ptr_;
}
explicit operator bool() const noexcept {
return (ptr_ != nullptr);
}
friend bool operator == (const shared_ptr& lhs, const shared_ptr& rhs) noexcept {
return (lhs.ptr_ == rhs.ptr_);
}
friend bool operator != (const shared_ptr& lhs, const shared_ptr& rhs) noexcept {
return !(lhs == rhs);
}
}; // class shared_ptr
template <typename T>
void swap(shared_ptr<T>& lhs, shared_ptr<T>& rhs) { // swap function in namespace to facilitate ADL
lhs.swap(rhs);
}
} // namespace kapil
#endif
c++ c++11 pointers
$endgroup$
add a comment |
$begingroup$
This is an implementation to simulate the basic functionality of c++ shared_ptr.
This doesn't provide features like custom deleter and make_shared().
I would really appreciate any feedback to improve the below code, any other api's that I should be providing etc.
#ifndef SHARED_PTR_H_
#define SHARED_PTR_H_
#include <utility>
namespace kapil {
template <typename T>
class shared_ptr {
private:
T* ptr_; // data pointer
int* ref_count_; // reference count pointer
void decrement_ref_count_and_delete_if_needed() {
if (ref_count_) {
--(*ref_count_);
if (*ref_count_ == 0) {
delete ptr_;
delete ref_count_;
ptr_ = nullptr;
ref_count_ = nullptr;
}
}
}
public:
constexpr shared_ptr() noexcept : ptr_{nullptr}, ref_count_{nullptr} {}
constexpr explicit shared_ptr(T* ptr) { // constructor
ptr_ = ptr;
ref_count_ = new int{1};
}
shared_ptr(const shared_ptr& other) noexcept { // copy constructor
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
if (ref_count_ != nullptr) {
++(*ref_count_);
}
}
shared_ptr(shared_ptr&& other) noexcept { // move constructor
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
other.ptr_ = nullptr;
other.ref_count_ = nullptr;
}
~shared_ptr() noexcept { // destructor
decrement_ref_count_and_delete_if_needed();
}
shared_ptr& operator = (const shared_ptr& other) noexcept { // assignent operator
if (this != &other) {
decrement_ref_count_and_delete_if_needed();
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
if (ref_count_) {
++(*ref_count_);
}
}
return *this;
}
shared_ptr& operator = (shared_ptr&& other) noexcept { // move assignment operator
*this = other;
}
T* get() const noexcept {
return ptr_;
}
void reset() noexcept {
decrement_ref_count_and_delete_if_needed();
}
void reset(T* ptr) {
decrement_ref_count_and_delete_if_needed();
ptr_ = ptr;
if (!ref_count_) {
ref_count_ = new int{1};
}
*ref_count_ = 1;
}
int use_count() const noexcept {
return *ref_count_;
}
void swap (shared_ptr& other) {
std::swap(ptr_, other.ptr_);
std::swap(ref_count_, other.ref_count_);
}
T& operator * () const {
return *ptr_;
}
T* operator -> () const noexcept {
return ptr_;
}
explicit operator bool() const noexcept {
return (ptr_ != nullptr);
}
friend bool operator == (const shared_ptr& lhs, const shared_ptr& rhs) noexcept {
return (lhs.ptr_ == rhs.ptr_);
}
friend bool operator != (const shared_ptr& lhs, const shared_ptr& rhs) noexcept {
return !(lhs == rhs);
}
}; // class shared_ptr
template <typename T>
void swap(shared_ptr<T>& lhs, shared_ptr<T>& rhs) { // swap function in namespace to facilitate ADL
lhs.swap(rhs);
}
} // namespace kapil
#endif
c++ c++11 pointers
$endgroup$
add a comment |
$begingroup$
This is an implementation to simulate the basic functionality of c++ shared_ptr.
This doesn't provide features like custom deleter and make_shared().
I would really appreciate any feedback to improve the below code, any other api's that I should be providing etc.
#ifndef SHARED_PTR_H_
#define SHARED_PTR_H_
#include <utility>
namespace kapil {
template <typename T>
class shared_ptr {
private:
T* ptr_; // data pointer
int* ref_count_; // reference count pointer
void decrement_ref_count_and_delete_if_needed() {
if (ref_count_) {
--(*ref_count_);
if (*ref_count_ == 0) {
delete ptr_;
delete ref_count_;
ptr_ = nullptr;
ref_count_ = nullptr;
}
}
}
public:
constexpr shared_ptr() noexcept : ptr_{nullptr}, ref_count_{nullptr} {}
constexpr explicit shared_ptr(T* ptr) { // constructor
ptr_ = ptr;
ref_count_ = new int{1};
}
shared_ptr(const shared_ptr& other) noexcept { // copy constructor
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
if (ref_count_ != nullptr) {
++(*ref_count_);
}
}
shared_ptr(shared_ptr&& other) noexcept { // move constructor
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
other.ptr_ = nullptr;
other.ref_count_ = nullptr;
}
~shared_ptr() noexcept { // destructor
decrement_ref_count_and_delete_if_needed();
}
shared_ptr& operator = (const shared_ptr& other) noexcept { // assignent operator
if (this != &other) {
decrement_ref_count_and_delete_if_needed();
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
if (ref_count_) {
++(*ref_count_);
}
}
return *this;
}
shared_ptr& operator = (shared_ptr&& other) noexcept { // move assignment operator
*this = other;
}
T* get() const noexcept {
return ptr_;
}
void reset() noexcept {
decrement_ref_count_and_delete_if_needed();
}
void reset(T* ptr) {
decrement_ref_count_and_delete_if_needed();
ptr_ = ptr;
if (!ref_count_) {
ref_count_ = new int{1};
}
*ref_count_ = 1;
}
int use_count() const noexcept {
return *ref_count_;
}
void swap (shared_ptr& other) {
std::swap(ptr_, other.ptr_);
std::swap(ref_count_, other.ref_count_);
}
T& operator * () const {
return *ptr_;
}
T* operator -> () const noexcept {
return ptr_;
}
explicit operator bool() const noexcept {
return (ptr_ != nullptr);
}
friend bool operator == (const shared_ptr& lhs, const shared_ptr& rhs) noexcept {
return (lhs.ptr_ == rhs.ptr_);
}
friend bool operator != (const shared_ptr& lhs, const shared_ptr& rhs) noexcept {
return !(lhs == rhs);
}
}; // class shared_ptr
template <typename T>
void swap(shared_ptr<T>& lhs, shared_ptr<T>& rhs) { // swap function in namespace to facilitate ADL
lhs.swap(rhs);
}
} // namespace kapil
#endif
c++ c++11 pointers
$endgroup$
This is an implementation to simulate the basic functionality of c++ shared_ptr.
This doesn't provide features like custom deleter and make_shared().
I would really appreciate any feedback to improve the below code, any other api's that I should be providing etc.
#ifndef SHARED_PTR_H_
#define SHARED_PTR_H_
#include <utility>
namespace kapil {
template <typename T>
class shared_ptr {
private:
T* ptr_; // data pointer
int* ref_count_; // reference count pointer
void decrement_ref_count_and_delete_if_needed() {
if (ref_count_) {
--(*ref_count_);
if (*ref_count_ == 0) {
delete ptr_;
delete ref_count_;
ptr_ = nullptr;
ref_count_ = nullptr;
}
}
}
public:
constexpr shared_ptr() noexcept : ptr_{nullptr}, ref_count_{nullptr} {}
constexpr explicit shared_ptr(T* ptr) { // constructor
ptr_ = ptr;
ref_count_ = new int{1};
}
shared_ptr(const shared_ptr& other) noexcept { // copy constructor
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
if (ref_count_ != nullptr) {
++(*ref_count_);
}
}
shared_ptr(shared_ptr&& other) noexcept { // move constructor
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
other.ptr_ = nullptr;
other.ref_count_ = nullptr;
}
~shared_ptr() noexcept { // destructor
decrement_ref_count_and_delete_if_needed();
}
shared_ptr& operator = (const shared_ptr& other) noexcept { // assignent operator
if (this != &other) {
decrement_ref_count_and_delete_if_needed();
ptr_ = other.ptr_;
ref_count_ = other.ref_count_;
if (ref_count_) {
++(*ref_count_);
}
}
return *this;
}
shared_ptr& operator = (shared_ptr&& other) noexcept { // move assignment operator
*this = other;
}
T* get() const noexcept {
return ptr_;
}
void reset() noexcept {
decrement_ref_count_and_delete_if_needed();
}
void reset(T* ptr) {
decrement_ref_count_and_delete_if_needed();
ptr_ = ptr;
if (!ref_count_) {
ref_count_ = new int{1};
}
*ref_count_ = 1;
}
int use_count() const noexcept {
return *ref_count_;
}
void swap (shared_ptr& other) {
std::swap(ptr_, other.ptr_);
std::swap(ref_count_, other.ref_count_);
}
T& operator * () const {
return *ptr_;
}
T* operator -> () const noexcept {
return ptr_;
}
explicit operator bool() const noexcept {
return (ptr_ != nullptr);
}
friend bool operator == (const shared_ptr& lhs, const shared_ptr& rhs) noexcept {
return (lhs.ptr_ == rhs.ptr_);
}
friend bool operator != (const shared_ptr& lhs, const shared_ptr& rhs) noexcept {
return !(lhs == rhs);
}
}; // class shared_ptr
template <typename T>
void swap(shared_ptr<T>& lhs, shared_ptr<T>& rhs) { // swap function in namespace to facilitate ADL
lhs.swap(rhs);
}
} // namespace kapil
#endif
c++ c++11 pointers
c++ c++11 pointers
asked 2 mins ago
kapilkapil
524
524
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215223%2fshared-ptr-basic-implementation-for-non-array-types%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215223%2fshared-ptr-basic-implementation-for-non-array-types%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown