Extracting attribute value from multiple XML nodes in golang? The 2019 Stack Overflow...

What to do when moving next to a bird sanctuary with a loosely-domesticated cat?

Geography at the pixel level

Can we generate random numbers using irrational numbers like π and e?

Pokemon Turn Based battle (Python)

If I can cast sorceries at instant speed, can I use sorcery-speed activated abilities at instant speed?

"as much details as you can remember"

Getting crown tickets for Statue of Liberty

Is one supposed to eat the zero'ah (shank bone) from the Seder plate?

Why are there uneven bright areas in this photo of black hole?

Why not take a picture of a closer black hole?

How to obtain a position of last non-zero element

What is this business jet?

How to translate "being like"?

Did Scotland spend $250,000 for the slogan "Welcome to Scotland"?

How did passengers keep warm on sail ships?

Loose spokes after only a few rides

What is this sharp, curved notch on my knife for?

Why doesn't UInt have a toDouble()?

Did any laptop computers have a built-in 5 1/4 inch floppy drive?

If I score a critical hit on an 18 or higher, what are my chances of getting a critical hit if I roll 3d20?

Deal with toxic manager when you can't quit

What does Linus Torvalds mean when he says that Git "never ever" tracks a file?

How to charge AirPods to keep battery healthy?

Is it ok to offer lower paid work as a trial period before negotiating for a full-time job?



Extracting attribute value from multiple XML nodes in golang?



The 2019 Stack Overflow Developer Survey Results Are InBetter way to get the XML attribute value?Extracting key information from a directory of XML filesPython XML - extracting informationChecking multiple XML in PHPDistinct List of attribute values from XML, using a pre-defined set of attribute namesParse child value from XML using ezxmlGolang visitor pattern for marshaling shapes as JSON, and XMLModify XML attribute based on element valueXML graphing, and attribute existenceGet attribute values with LINQ to XML





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







1












$begingroup$


I'm attempting to parse an SVG file to get all of the colors that are present in the file. SVGs are XML based and their structure can vary a bit. For example:



<svg viewBox="-80 -80 160 160">
<g stroke="black" fill="none">
<path d='...' fill='#0FF'/>
<path d='...' fill='#F0F'/>
...
</g>
</svg>


and



<svg viewBox="0 0 100 100">
<a>
<path d="..." stroke="black" fill="red"/>
<ellipse stroke="black" fill="white" cx="50" cy="40" rx="22" ry="35"/>
<circle cx="50" cy="40" r="5" stroke="black" fill="red"/>
</a>
</svg>


and



<svg viewBox="0 0 80 120">
<rect id="background-rect" x="0%" y="0%" width="100%" height="100%" fill="#aaaaaa"/>
</svg>


Are all examples of valid SVGs. At first I attempted to create the underlying structs that would allow me to represent all of these structures but then I decided to take a more generic approach that would focus soley on the fill attribute which is all I care about:



type GenericNode struct {
XMLName xml.Name
Fill string `xml:"fill,attr"`
Nodes []GenericNode `xml:",any"`
}

func (s *SVGController) GetColorsFromXML() []string {
xmlFile, _ := os.Open(s.Path)
byteValue, _ := ioutil.ReadAll(xmlFile)
var svg GenericNode
xml.Unmarshal(byteValue, &svg)

// Using a map here to avoid having to worry about having
// duplicate colors in the color slice
colorMap := make(map[string]struct{})
colorMap = getSVGColors(svg, colorMap)

// Once we have a complete color map extract all the keys
// to an array and return it.
colors := make([]string, len(colorMap))
i := 0
for k := range colorMap {
colors[i] = k
i++
}
return colors
}

func getSVGColors(svg GenericNode, colors map[string]struct{}) map[string]struct{} {
if svg.Fill != "" && strings.ToLower(svg.Fill) != "none" {
colors[svg.Fill] = struct{}{}
}
for _, node := range svg.Nodes {
colors = getSVGColors(node, colors)
}
return colors
}


Is this a reasonable approach to take? Am I doing anything here that should be avoided?









share









$endgroup$



















    1












    $begingroup$


    I'm attempting to parse an SVG file to get all of the colors that are present in the file. SVGs are XML based and their structure can vary a bit. For example:



    <svg viewBox="-80 -80 160 160">
    <g stroke="black" fill="none">
    <path d='...' fill='#0FF'/>
    <path d='...' fill='#F0F'/>
    ...
    </g>
    </svg>


    and



    <svg viewBox="0 0 100 100">
    <a>
    <path d="..." stroke="black" fill="red"/>
    <ellipse stroke="black" fill="white" cx="50" cy="40" rx="22" ry="35"/>
    <circle cx="50" cy="40" r="5" stroke="black" fill="red"/>
    </a>
    </svg>


    and



    <svg viewBox="0 0 80 120">
    <rect id="background-rect" x="0%" y="0%" width="100%" height="100%" fill="#aaaaaa"/>
    </svg>


    Are all examples of valid SVGs. At first I attempted to create the underlying structs that would allow me to represent all of these structures but then I decided to take a more generic approach that would focus soley on the fill attribute which is all I care about:



    type GenericNode struct {
    XMLName xml.Name
    Fill string `xml:"fill,attr"`
    Nodes []GenericNode `xml:",any"`
    }

    func (s *SVGController) GetColorsFromXML() []string {
    xmlFile, _ := os.Open(s.Path)
    byteValue, _ := ioutil.ReadAll(xmlFile)
    var svg GenericNode
    xml.Unmarshal(byteValue, &svg)

    // Using a map here to avoid having to worry about having
    // duplicate colors in the color slice
    colorMap := make(map[string]struct{})
    colorMap = getSVGColors(svg, colorMap)

    // Once we have a complete color map extract all the keys
    // to an array and return it.
    colors := make([]string, len(colorMap))
    i := 0
    for k := range colorMap {
    colors[i] = k
    i++
    }
    return colors
    }

    func getSVGColors(svg GenericNode, colors map[string]struct{}) map[string]struct{} {
    if svg.Fill != "" && strings.ToLower(svg.Fill) != "none" {
    colors[svg.Fill] = struct{}{}
    }
    for _, node := range svg.Nodes {
    colors = getSVGColors(node, colors)
    }
    return colors
    }


    Is this a reasonable approach to take? Am I doing anything here that should be avoided?









    share









    $endgroup$















      1












      1








      1





      $begingroup$


      I'm attempting to parse an SVG file to get all of the colors that are present in the file. SVGs are XML based and their structure can vary a bit. For example:



      <svg viewBox="-80 -80 160 160">
      <g stroke="black" fill="none">
      <path d='...' fill='#0FF'/>
      <path d='...' fill='#F0F'/>
      ...
      </g>
      </svg>


      and



      <svg viewBox="0 0 100 100">
      <a>
      <path d="..." stroke="black" fill="red"/>
      <ellipse stroke="black" fill="white" cx="50" cy="40" rx="22" ry="35"/>
      <circle cx="50" cy="40" r="5" stroke="black" fill="red"/>
      </a>
      </svg>


      and



      <svg viewBox="0 0 80 120">
      <rect id="background-rect" x="0%" y="0%" width="100%" height="100%" fill="#aaaaaa"/>
      </svg>


      Are all examples of valid SVGs. At first I attempted to create the underlying structs that would allow me to represent all of these structures but then I decided to take a more generic approach that would focus soley on the fill attribute which is all I care about:



      type GenericNode struct {
      XMLName xml.Name
      Fill string `xml:"fill,attr"`
      Nodes []GenericNode `xml:",any"`
      }

      func (s *SVGController) GetColorsFromXML() []string {
      xmlFile, _ := os.Open(s.Path)
      byteValue, _ := ioutil.ReadAll(xmlFile)
      var svg GenericNode
      xml.Unmarshal(byteValue, &svg)

      // Using a map here to avoid having to worry about having
      // duplicate colors in the color slice
      colorMap := make(map[string]struct{})
      colorMap = getSVGColors(svg, colorMap)

      // Once we have a complete color map extract all the keys
      // to an array and return it.
      colors := make([]string, len(colorMap))
      i := 0
      for k := range colorMap {
      colors[i] = k
      i++
      }
      return colors
      }

      func getSVGColors(svg GenericNode, colors map[string]struct{}) map[string]struct{} {
      if svg.Fill != "" && strings.ToLower(svg.Fill) != "none" {
      colors[svg.Fill] = struct{}{}
      }
      for _, node := range svg.Nodes {
      colors = getSVGColors(node, colors)
      }
      return colors
      }


      Is this a reasonable approach to take? Am I doing anything here that should be avoided?









      share









      $endgroup$




      I'm attempting to parse an SVG file to get all of the colors that are present in the file. SVGs are XML based and their structure can vary a bit. For example:



      <svg viewBox="-80 -80 160 160">
      <g stroke="black" fill="none">
      <path d='...' fill='#0FF'/>
      <path d='...' fill='#F0F'/>
      ...
      </g>
      </svg>


      and



      <svg viewBox="0 0 100 100">
      <a>
      <path d="..." stroke="black" fill="red"/>
      <ellipse stroke="black" fill="white" cx="50" cy="40" rx="22" ry="35"/>
      <circle cx="50" cy="40" r="5" stroke="black" fill="red"/>
      </a>
      </svg>


      and



      <svg viewBox="0 0 80 120">
      <rect id="background-rect" x="0%" y="0%" width="100%" height="100%" fill="#aaaaaa"/>
      </svg>


      Are all examples of valid SVGs. At first I attempted to create the underlying structs that would allow me to represent all of these structures but then I decided to take a more generic approach that would focus soley on the fill attribute which is all I care about:



      type GenericNode struct {
      XMLName xml.Name
      Fill string `xml:"fill,attr"`
      Nodes []GenericNode `xml:",any"`
      }

      func (s *SVGController) GetColorsFromXML() []string {
      xmlFile, _ := os.Open(s.Path)
      byteValue, _ := ioutil.ReadAll(xmlFile)
      var svg GenericNode
      xml.Unmarshal(byteValue, &svg)

      // Using a map here to avoid having to worry about having
      // duplicate colors in the color slice
      colorMap := make(map[string]struct{})
      colorMap = getSVGColors(svg, colorMap)

      // Once we have a complete color map extract all the keys
      // to an array and return it.
      colors := make([]string, len(colorMap))
      i := 0
      for k := range colorMap {
      colors[i] = k
      i++
      }
      return colors
      }

      func getSVGColors(svg GenericNode, colors map[string]struct{}) map[string]struct{} {
      if svg.Fill != "" && strings.ToLower(svg.Fill) != "none" {
      colors[svg.Fill] = struct{}{}
      }
      for _, node := range svg.Nodes {
      colors = getSVGColors(node, colors)
      }
      return colors
      }


      Is this a reasonable approach to take? Am I doing anything here that should be avoided?







      xml go





      share












      share










      share



      share










      asked 3 mins ago









      Abe MiesslerAbe Miessler

      2761210




      2761210






















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217296%2fextracting-attribute-value-from-multiple-xml-nodes-in-golang%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217296%2fextracting-attribute-value-from-multiple-xml-nodes-in-golang%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Fairchild Swearingen Metro Inhaltsverzeichnis Geschichte | Innenausstattung | Nutzung | Zwischenfälle...

          Pilgersdorf Inhaltsverzeichnis Geografie | Geschichte | Bevölkerungsentwicklung | Politik | Kultur...

          Marineschifffahrtleitung Inhaltsverzeichnis Geschichte | Heutige Organisation der NATO | Nationale und...