A countdown clock in TypeScriptCountdown timerTypeScript Dictionary classResource pooling in...

How do we create new idioms and use them in a novel?

Doesn't allowing a user mode program to access kernel space memory and execute the IN and OUT instructions defeat the purpose of having CPU modes?

What will happen if my luggage gets delayed?

Do items de-spawn?

Vocabulary for giving just numbers, not a full answer

Is a piano played in the same way as a harmonium?

Plausibility of Mushroom Buildings

In the late 1940’s to early 1950’s what technology was available that could melt a LOT of ice?

Confusion about Complex Continued Fraction

Can't make sense of a paragraph from Lovecraft

What do *foreign films* mean for an American?

Can we track matter through time by looking at different depths in space?

Can one live in the U.S. and not use a credit card?

Why is there an extra space when I type "ls" in the Desktop directory?

Can I use a violin G string for D?

Why is a very small peak with larger m/z not considered to be the molecular ion?

What materials can be used to make a humanoid skin warm?

Why does cron require MTA for logging?

I reported the illegal activity of my boss to his boss. My boss found out. Now I am being punished. What should I do?

Are small insurances worth it?

Was it really inappropriate to write a pull request for the company I interviewed with?

Should I take out a loan for a friend to invest on my behalf?

Rationale to prefer local variables over instance variables?

Which situations would cause a company to ground or recall a aircraft series?



A countdown clock in TypeScript


Countdown timerTypeScript Dictionary classResource pooling in TypeScriptCountdown AppIndicatorAngular 2 clock with RxJS ObservablePomodoro Countdown ClockWhich will be better declaration go to with TypeScript?Pomodoro countdown timer synced to the clockTypescript logger classAlgorithm to find the number of years, months, days, etc between two dates













1












$begingroup$


The gist of the code is, you give it a date, it will start counting down how many days, hours, minutes and seconds left by emitting an event 'countDown' and once 0 is reached 'expired' event is emitted.



How can this code be improved?



class DateCountDown {
listeners: Map<string, Array<Function>>;

constructor(date: Date) {

this.startCountDown(date);
this.listeners = new Map();
this.listeners.set("countDown", []);
this.listeners.set("expired", []);
}

on(eventName: "countDown", listener: (values: CountDownValues) => void);
on(eventName: "expired", listener: (isExpired: boolean) => void);
on(eventName: string, listener: Function) {
this.listeners.get(eventName).push(listener);
}


startCountDown(date: Date) {
const thousand = 1000;
const sixty = 60;
const twentyfour = 24;

const timer = setInterval(() => {
const now = new Date().getTime();
const t = date.valueOf() - now;

const days = Math.floor(t / (thousand * sixty * sixty * twentyfour));
const hours = Math.floor((t % (thousand * sixty * sixty * twentyfour)) / (thousand * sixty * sixty));
const minutes = Math.floor((t % (thousand * sixty * sixty)) / (thousand * sixty));
const seconds = Math.floor((t % (thousand * sixty)) / thousand);

if (t <= 0) {
clearInterval(timer);
this.listeners.get("expired").forEach(listener =>
listener(true));
return;
}

this.listeners.get("countDown").forEach(listener =>
listener(new CountDownValues(days, hours, minutes, seconds))
);
}, 1000);
}
}
class CountDownValues {
days: number;
hours: number;
minutes: number;
seconds: number;

constructor(days: number, hours: number, minutes: number, seconds: number) {
this.days = days;
this.hours = hours;
this.minutes = minutes;
this.seconds = seconds;
}

}
var date = new Date();
date.setSeconds(date.getSeconds() + 20);

let countDown = new DateCountDown(date);

countDown.on("countDown", values => {
console.log("from first", values);
});
countDown.on("expired", isExpired => {
console.log("expired:", isExpired);
});









share|improve this question











$endgroup$

















    1












    $begingroup$


    The gist of the code is, you give it a date, it will start counting down how many days, hours, minutes and seconds left by emitting an event 'countDown' and once 0 is reached 'expired' event is emitted.



    How can this code be improved?



    class DateCountDown {
    listeners: Map<string, Array<Function>>;

    constructor(date: Date) {

    this.startCountDown(date);
    this.listeners = new Map();
    this.listeners.set("countDown", []);
    this.listeners.set("expired", []);
    }

    on(eventName: "countDown", listener: (values: CountDownValues) => void);
    on(eventName: "expired", listener: (isExpired: boolean) => void);
    on(eventName: string, listener: Function) {
    this.listeners.get(eventName).push(listener);
    }


    startCountDown(date: Date) {
    const thousand = 1000;
    const sixty = 60;
    const twentyfour = 24;

    const timer = setInterval(() => {
    const now = new Date().getTime();
    const t = date.valueOf() - now;

    const days = Math.floor(t / (thousand * sixty * sixty * twentyfour));
    const hours = Math.floor((t % (thousand * sixty * sixty * twentyfour)) / (thousand * sixty * sixty));
    const minutes = Math.floor((t % (thousand * sixty * sixty)) / (thousand * sixty));
    const seconds = Math.floor((t % (thousand * sixty)) / thousand);

    if (t <= 0) {
    clearInterval(timer);
    this.listeners.get("expired").forEach(listener =>
    listener(true));
    return;
    }

    this.listeners.get("countDown").forEach(listener =>
    listener(new CountDownValues(days, hours, minutes, seconds))
    );
    }, 1000);
    }
    }
    class CountDownValues {
    days: number;
    hours: number;
    minutes: number;
    seconds: number;

    constructor(days: number, hours: number, minutes: number, seconds: number) {
    this.days = days;
    this.hours = hours;
    this.minutes = minutes;
    this.seconds = seconds;
    }

    }
    var date = new Date();
    date.setSeconds(date.getSeconds() + 20);

    let countDown = new DateCountDown(date);

    countDown.on("countDown", values => {
    console.log("from first", values);
    });
    countDown.on("expired", isExpired => {
    console.log("expired:", isExpired);
    });









    share|improve this question











    $endgroup$















      1












      1








      1





      $begingroup$


      The gist of the code is, you give it a date, it will start counting down how many days, hours, minutes and seconds left by emitting an event 'countDown' and once 0 is reached 'expired' event is emitted.



      How can this code be improved?



      class DateCountDown {
      listeners: Map<string, Array<Function>>;

      constructor(date: Date) {

      this.startCountDown(date);
      this.listeners = new Map();
      this.listeners.set("countDown", []);
      this.listeners.set("expired", []);
      }

      on(eventName: "countDown", listener: (values: CountDownValues) => void);
      on(eventName: "expired", listener: (isExpired: boolean) => void);
      on(eventName: string, listener: Function) {
      this.listeners.get(eventName).push(listener);
      }


      startCountDown(date: Date) {
      const thousand = 1000;
      const sixty = 60;
      const twentyfour = 24;

      const timer = setInterval(() => {
      const now = new Date().getTime();
      const t = date.valueOf() - now;

      const days = Math.floor(t / (thousand * sixty * sixty * twentyfour));
      const hours = Math.floor((t % (thousand * sixty * sixty * twentyfour)) / (thousand * sixty * sixty));
      const minutes = Math.floor((t % (thousand * sixty * sixty)) / (thousand * sixty));
      const seconds = Math.floor((t % (thousand * sixty)) / thousand);

      if (t <= 0) {
      clearInterval(timer);
      this.listeners.get("expired").forEach(listener =>
      listener(true));
      return;
      }

      this.listeners.get("countDown").forEach(listener =>
      listener(new CountDownValues(days, hours, minutes, seconds))
      );
      }, 1000);
      }
      }
      class CountDownValues {
      days: number;
      hours: number;
      minutes: number;
      seconds: number;

      constructor(days: number, hours: number, minutes: number, seconds: number) {
      this.days = days;
      this.hours = hours;
      this.minutes = minutes;
      this.seconds = seconds;
      }

      }
      var date = new Date();
      date.setSeconds(date.getSeconds() + 20);

      let countDown = new DateCountDown(date);

      countDown.on("countDown", values => {
      console.log("from first", values);
      });
      countDown.on("expired", isExpired => {
      console.log("expired:", isExpired);
      });









      share|improve this question











      $endgroup$




      The gist of the code is, you give it a date, it will start counting down how many days, hours, minutes and seconds left by emitting an event 'countDown' and once 0 is reached 'expired' event is emitted.



      How can this code be improved?



      class DateCountDown {
      listeners: Map<string, Array<Function>>;

      constructor(date: Date) {

      this.startCountDown(date);
      this.listeners = new Map();
      this.listeners.set("countDown", []);
      this.listeners.set("expired", []);
      }

      on(eventName: "countDown", listener: (values: CountDownValues) => void);
      on(eventName: "expired", listener: (isExpired: boolean) => void);
      on(eventName: string, listener: Function) {
      this.listeners.get(eventName).push(listener);
      }


      startCountDown(date: Date) {
      const thousand = 1000;
      const sixty = 60;
      const twentyfour = 24;

      const timer = setInterval(() => {
      const now = new Date().getTime();
      const t = date.valueOf() - now;

      const days = Math.floor(t / (thousand * sixty * sixty * twentyfour));
      const hours = Math.floor((t % (thousand * sixty * sixty * twentyfour)) / (thousand * sixty * sixty));
      const minutes = Math.floor((t % (thousand * sixty * sixty)) / (thousand * sixty));
      const seconds = Math.floor((t % (thousand * sixty)) / thousand);

      if (t <= 0) {
      clearInterval(timer);
      this.listeners.get("expired").forEach(listener =>
      listener(true));
      return;
      }

      this.listeners.get("countDown").forEach(listener =>
      listener(new CountDownValues(days, hours, minutes, seconds))
      );
      }, 1000);
      }
      }
      class CountDownValues {
      days: number;
      hours: number;
      minutes: number;
      seconds: number;

      constructor(days: number, hours: number, minutes: number, seconds: number) {
      this.days = days;
      this.hours = hours;
      this.minutes = minutes;
      this.seconds = seconds;
      }

      }
      var date = new Date();
      date.setSeconds(date.getSeconds() + 20);

      let countDown = new DateCountDown(date);

      countDown.on("countDown", values => {
      console.log("from first", values);
      });
      countDown.on("expired", isExpired => {
      console.log("expired:", isExpired);
      });






      timer typescript






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 1 min ago









      200_success

      130k16153419




      130k16153419










      asked 4 hours ago









      ZoinkyZoinky

      1162




      1162






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215161%2fa-countdown-clock-in-typescript%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215161%2fa-countdown-clock-in-typescript%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Fairchild Swearingen Metro Inhaltsverzeichnis Geschichte | Innenausstattung | Nutzung | Zwischenfälle...

          Pilgersdorf Inhaltsverzeichnis Geografie | Geschichte | Bevölkerungsentwicklung | Politik | Kultur...

          Marineschifffahrtleitung Inhaltsverzeichnis Geschichte | Heutige Organisation der NATO | Nationale und...