Grouping models without dictionary Announcing the arrival of Valued Associate #679: Cesar...

Dating a Former Employee

また usage in a dictionary

How do pianists reach extremely loud dynamics?

Denied boarding although I have proper visa and documentation. To whom should I make a complaint?

Is there such thing as an Availability Group failover trigger?

How to convince students of the implication truth values?

How do I stop a creek from eroding my steep embankment?

Can you use the Shield Master feat to shove someone before you make an attack by using a Readied action?

An adverb for when you're not exaggerating

Is it a good idea to use CNN to classify 1D signal?

Is it cost-effective to upgrade an old-ish Giant Escape R3 commuter bike with entry-level branded parts (wheels, drivetrain)?

Can a party unilaterally change candidates in preparation for a General election?

Is "Reachable Object" really an NP-complete problem?

Do wooden building fires get hotter than 600°C?

What font is "z" in "z-score"?

Is this homebrew Lady of Pain warlock patron balanced?

What does "lightly crushed" mean for cardamon pods?

Why didn't Eitri join the fight?

When was Kai Tak permanently closed to cargo service?

Should I use a zero-interest credit card for a large one-time purchase?

How would a mousetrap for use in space work?

How to answer "Have you ever been terminated?"

old style "caution" boxes

Most bit efficient text communication method?



Grouping models without dictionary



Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Haskell Bencoded Dictionary ParserSwift complexities with DictionaryOrdered dictionary in swift 2Grouping an array by postId and userIdTime manipulation for notification remindersNotifying view controller of changes to any of five types of modelsSimple wrapper function grouping and summarising variableGrouping array elements into batches of at most threeExtension for grouping array into two dimensional array based on element ([] -> [[]])Grouping Date Objects by year and month





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







1












$begingroup$


I want to group an array of structs only using arrays into an array of new structs. In this example I want to group the Person structs by Job and put them in new Department structs and put them in an array.



enum Job {
case developer
case programmer
case coder
}

struct Person {
let id: Int
let job: Job
}

struct Department {
let job: Job
var staff: [Person]

mutating func addStaff(_ person: Person) {
staff.append(person)
}
}

let initial = [
Person(id: 0, job: .developer),
Person(id: 1, job: .developer),
Person(id: 2, job: .programmer),
Person(id: 3, job: .programmer),
Person(id: 4, job: .coder)
]

func combinator(accumulator: [Department], current: Person) -> [Department] {
var accumulator = accumulator

if let index = accumulator.index(where: { $0.job == current.job }) {

var department = accumulator[index]
department.staff.append(current)
accumulator[index] = department
} else {
accumulator.append(Department(job: current.job, staff: [current]))
}

return accumulator
}

var departments: [Department] = initial.reduce([], combinator)


I feel like the if statement in the combinator(accumulator:current:) function is a bit clunky, is there a better way to write that part or any other part of this piece of code?










share|improve this question









$endgroup$




bumped to the homepage by Community 1 min ago


This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.






















    1












    $begingroup$


    I want to group an array of structs only using arrays into an array of new structs. In this example I want to group the Person structs by Job and put them in new Department structs and put them in an array.



    enum Job {
    case developer
    case programmer
    case coder
    }

    struct Person {
    let id: Int
    let job: Job
    }

    struct Department {
    let job: Job
    var staff: [Person]

    mutating func addStaff(_ person: Person) {
    staff.append(person)
    }
    }

    let initial = [
    Person(id: 0, job: .developer),
    Person(id: 1, job: .developer),
    Person(id: 2, job: .programmer),
    Person(id: 3, job: .programmer),
    Person(id: 4, job: .coder)
    ]

    func combinator(accumulator: [Department], current: Person) -> [Department] {
    var accumulator = accumulator

    if let index = accumulator.index(where: { $0.job == current.job }) {

    var department = accumulator[index]
    department.staff.append(current)
    accumulator[index] = department
    } else {
    accumulator.append(Department(job: current.job, staff: [current]))
    }

    return accumulator
    }

    var departments: [Department] = initial.reduce([], combinator)


    I feel like the if statement in the combinator(accumulator:current:) function is a bit clunky, is there a better way to write that part or any other part of this piece of code?










    share|improve this question









    $endgroup$




    bumped to the homepage by Community 1 min ago


    This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.


















      1












      1








      1





      $begingroup$


      I want to group an array of structs only using arrays into an array of new structs. In this example I want to group the Person structs by Job and put them in new Department structs and put them in an array.



      enum Job {
      case developer
      case programmer
      case coder
      }

      struct Person {
      let id: Int
      let job: Job
      }

      struct Department {
      let job: Job
      var staff: [Person]

      mutating func addStaff(_ person: Person) {
      staff.append(person)
      }
      }

      let initial = [
      Person(id: 0, job: .developer),
      Person(id: 1, job: .developer),
      Person(id: 2, job: .programmer),
      Person(id: 3, job: .programmer),
      Person(id: 4, job: .coder)
      ]

      func combinator(accumulator: [Department], current: Person) -> [Department] {
      var accumulator = accumulator

      if let index = accumulator.index(where: { $0.job == current.job }) {

      var department = accumulator[index]
      department.staff.append(current)
      accumulator[index] = department
      } else {
      accumulator.append(Department(job: current.job, staff: [current]))
      }

      return accumulator
      }

      var departments: [Department] = initial.reduce([], combinator)


      I feel like the if statement in the combinator(accumulator:current:) function is a bit clunky, is there a better way to write that part or any other part of this piece of code?










      share|improve this question









      $endgroup$




      I want to group an array of structs only using arrays into an array of new structs. In this example I want to group the Person structs by Job and put them in new Department structs and put them in an array.



      enum Job {
      case developer
      case programmer
      case coder
      }

      struct Person {
      let id: Int
      let job: Job
      }

      struct Department {
      let job: Job
      var staff: [Person]

      mutating func addStaff(_ person: Person) {
      staff.append(person)
      }
      }

      let initial = [
      Person(id: 0, job: .developer),
      Person(id: 1, job: .developer),
      Person(id: 2, job: .programmer),
      Person(id: 3, job: .programmer),
      Person(id: 4, job: .coder)
      ]

      func combinator(accumulator: [Department], current: Person) -> [Department] {
      var accumulator = accumulator

      if let index = accumulator.index(where: { $0.job == current.job }) {

      var department = accumulator[index]
      department.staff.append(current)
      accumulator[index] = department
      } else {
      accumulator.append(Department(job: current.job, staff: [current]))
      }

      return accumulator
      }

      var departments: [Department] = initial.reduce([], combinator)


      I feel like the if statement in the combinator(accumulator:current:) function is a bit clunky, is there a better way to write that part or any other part of this piece of code?







      functional-programming swift swift3






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Jun 22 '17 at 0:51









      richyrichy

      1134




      1134





      bumped to the homepage by Community 1 min ago


      This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.







      bumped to the homepage by Community 1 min ago


      This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.
























          1 Answer
          1






          active

          oldest

          votes


















          0












          $begingroup$

          Swift 4



          i would use the new swift 4 init(grouping:by:)



          since you create always new Departments then the following code is possible.



          if you have an existing [Department] then the code not fit your request.



          enum Job {
          case developer
          case programmer
          case coder
          }

          struct Person {
          let id: Int
          let job: Job
          }

          struct Department {
          let job: Job
          var staff: [Person]

          mutating func addStaff(_ person: Person) {
          staff.append(person)
          }
          }

          let initial = [
          Person(id: 0, job: .developer),
          Person(id: 1, job: .developer),
          Person(id: 2, job: .programmer),
          Person(id: 3, job: .programmer),
          Person(id: 4, job: .coder)
          ]

          let grouped = Dictionary(grouping: initial, by: { $0.job })
          let departments = grouped.map{ key, value in Department( job: key, staff: value )}


          ( NOTE: i don't tested it in playground - just from head to the answer)



          Swift 3



          in Swift 3 you can use an extension to the array to resolve this grouping



          public extension Sequence {
          func group<U: Hashable>(by key: (Iterator.Element) -> U) -> [U:[Iterator.Element]] {
          var categories: [U: [Iterator.Element]] = [:]
          for element in self {
          let key = key(element)
          if case nil = categories[key]?.append(element) {
          categories[key] = [element]
          }
          }
          return categories
          }
          }


          the extension is from here https://stackoverflow.com/a/31220067/1930509 and when you need a more performat grouping you can find it at the link






          share|improve this answer











          $endgroup$









          • 1




            $begingroup$
            This is specifically tagged swift3...
            $endgroup$
            – Mr. Xcoder
            Jun 25 '17 at 10:47










          • $begingroup$
            There existing some collection extension for grouping by for swift3 if he like my 2 lines solution.
            $endgroup$
            – muescha
            Jun 25 '17 at 15:48










          • $begingroup$
            Yeah sorry, I was looking for a Swift 3 solution
            $endgroup$
            – richy
            Jun 25 '17 at 19:08










          • $begingroup$
            @richy then you can use this extension for swift3 to have a groupby in Swift 3: stackoverflow.com/a/31220067/1930509
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53










          • $begingroup$
            with this a later upgrade to swift 4 is easy :)
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53












          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f166367%2fgrouping-models-without-dictionary%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          0












          $begingroup$

          Swift 4



          i would use the new swift 4 init(grouping:by:)



          since you create always new Departments then the following code is possible.



          if you have an existing [Department] then the code not fit your request.



          enum Job {
          case developer
          case programmer
          case coder
          }

          struct Person {
          let id: Int
          let job: Job
          }

          struct Department {
          let job: Job
          var staff: [Person]

          mutating func addStaff(_ person: Person) {
          staff.append(person)
          }
          }

          let initial = [
          Person(id: 0, job: .developer),
          Person(id: 1, job: .developer),
          Person(id: 2, job: .programmer),
          Person(id: 3, job: .programmer),
          Person(id: 4, job: .coder)
          ]

          let grouped = Dictionary(grouping: initial, by: { $0.job })
          let departments = grouped.map{ key, value in Department( job: key, staff: value )}


          ( NOTE: i don't tested it in playground - just from head to the answer)



          Swift 3



          in Swift 3 you can use an extension to the array to resolve this grouping



          public extension Sequence {
          func group<U: Hashable>(by key: (Iterator.Element) -> U) -> [U:[Iterator.Element]] {
          var categories: [U: [Iterator.Element]] = [:]
          for element in self {
          let key = key(element)
          if case nil = categories[key]?.append(element) {
          categories[key] = [element]
          }
          }
          return categories
          }
          }


          the extension is from here https://stackoverflow.com/a/31220067/1930509 and when you need a more performat grouping you can find it at the link






          share|improve this answer











          $endgroup$









          • 1




            $begingroup$
            This is specifically tagged swift3...
            $endgroup$
            – Mr. Xcoder
            Jun 25 '17 at 10:47










          • $begingroup$
            There existing some collection extension for grouping by for swift3 if he like my 2 lines solution.
            $endgroup$
            – muescha
            Jun 25 '17 at 15:48










          • $begingroup$
            Yeah sorry, I was looking for a Swift 3 solution
            $endgroup$
            – richy
            Jun 25 '17 at 19:08










          • $begingroup$
            @richy then you can use this extension for swift3 to have a groupby in Swift 3: stackoverflow.com/a/31220067/1930509
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53










          • $begingroup$
            with this a later upgrade to swift 4 is easy :)
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53
















          0












          $begingroup$

          Swift 4



          i would use the new swift 4 init(grouping:by:)



          since you create always new Departments then the following code is possible.



          if you have an existing [Department] then the code not fit your request.



          enum Job {
          case developer
          case programmer
          case coder
          }

          struct Person {
          let id: Int
          let job: Job
          }

          struct Department {
          let job: Job
          var staff: [Person]

          mutating func addStaff(_ person: Person) {
          staff.append(person)
          }
          }

          let initial = [
          Person(id: 0, job: .developer),
          Person(id: 1, job: .developer),
          Person(id: 2, job: .programmer),
          Person(id: 3, job: .programmer),
          Person(id: 4, job: .coder)
          ]

          let grouped = Dictionary(grouping: initial, by: { $0.job })
          let departments = grouped.map{ key, value in Department( job: key, staff: value )}


          ( NOTE: i don't tested it in playground - just from head to the answer)



          Swift 3



          in Swift 3 you can use an extension to the array to resolve this grouping



          public extension Sequence {
          func group<U: Hashable>(by key: (Iterator.Element) -> U) -> [U:[Iterator.Element]] {
          var categories: [U: [Iterator.Element]] = [:]
          for element in self {
          let key = key(element)
          if case nil = categories[key]?.append(element) {
          categories[key] = [element]
          }
          }
          return categories
          }
          }


          the extension is from here https://stackoverflow.com/a/31220067/1930509 and when you need a more performat grouping you can find it at the link






          share|improve this answer











          $endgroup$









          • 1




            $begingroup$
            This is specifically tagged swift3...
            $endgroup$
            – Mr. Xcoder
            Jun 25 '17 at 10:47










          • $begingroup$
            There existing some collection extension for grouping by for swift3 if he like my 2 lines solution.
            $endgroup$
            – muescha
            Jun 25 '17 at 15:48










          • $begingroup$
            Yeah sorry, I was looking for a Swift 3 solution
            $endgroup$
            – richy
            Jun 25 '17 at 19:08










          • $begingroup$
            @richy then you can use this extension for swift3 to have a groupby in Swift 3: stackoverflow.com/a/31220067/1930509
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53










          • $begingroup$
            with this a later upgrade to swift 4 is easy :)
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53














          0












          0








          0





          $begingroup$

          Swift 4



          i would use the new swift 4 init(grouping:by:)



          since you create always new Departments then the following code is possible.



          if you have an existing [Department] then the code not fit your request.



          enum Job {
          case developer
          case programmer
          case coder
          }

          struct Person {
          let id: Int
          let job: Job
          }

          struct Department {
          let job: Job
          var staff: [Person]

          mutating func addStaff(_ person: Person) {
          staff.append(person)
          }
          }

          let initial = [
          Person(id: 0, job: .developer),
          Person(id: 1, job: .developer),
          Person(id: 2, job: .programmer),
          Person(id: 3, job: .programmer),
          Person(id: 4, job: .coder)
          ]

          let grouped = Dictionary(grouping: initial, by: { $0.job })
          let departments = grouped.map{ key, value in Department( job: key, staff: value )}


          ( NOTE: i don't tested it in playground - just from head to the answer)



          Swift 3



          in Swift 3 you can use an extension to the array to resolve this grouping



          public extension Sequence {
          func group<U: Hashable>(by key: (Iterator.Element) -> U) -> [U:[Iterator.Element]] {
          var categories: [U: [Iterator.Element]] = [:]
          for element in self {
          let key = key(element)
          if case nil = categories[key]?.append(element) {
          categories[key] = [element]
          }
          }
          return categories
          }
          }


          the extension is from here https://stackoverflow.com/a/31220067/1930509 and when you need a more performat grouping you can find it at the link






          share|improve this answer











          $endgroup$



          Swift 4



          i would use the new swift 4 init(grouping:by:)



          since you create always new Departments then the following code is possible.



          if you have an existing [Department] then the code not fit your request.



          enum Job {
          case developer
          case programmer
          case coder
          }

          struct Person {
          let id: Int
          let job: Job
          }

          struct Department {
          let job: Job
          var staff: [Person]

          mutating func addStaff(_ person: Person) {
          staff.append(person)
          }
          }

          let initial = [
          Person(id: 0, job: .developer),
          Person(id: 1, job: .developer),
          Person(id: 2, job: .programmer),
          Person(id: 3, job: .programmer),
          Person(id: 4, job: .coder)
          ]

          let grouped = Dictionary(grouping: initial, by: { $0.job })
          let departments = grouped.map{ key, value in Department( job: key, staff: value )}


          ( NOTE: i don't tested it in playground - just from head to the answer)



          Swift 3



          in Swift 3 you can use an extension to the array to resolve this grouping



          public extension Sequence {
          func group<U: Hashable>(by key: (Iterator.Element) -> U) -> [U:[Iterator.Element]] {
          var categories: [U: [Iterator.Element]] = [:]
          for element in self {
          let key = key(element)
          if case nil = categories[key]?.append(element) {
          categories[key] = [element]
          }
          }
          return categories
          }
          }


          the extension is from here https://stackoverflow.com/a/31220067/1930509 and when you need a more performat grouping you can find it at the link







          share|improve this answer














          share|improve this answer



          share|improve this answer








          edited Jun 26 '17 at 16:01

























          answered Jun 22 '17 at 21:49









          mueschamuescha

          1765




          1765








          • 1




            $begingroup$
            This is specifically tagged swift3...
            $endgroup$
            – Mr. Xcoder
            Jun 25 '17 at 10:47










          • $begingroup$
            There existing some collection extension for grouping by for swift3 if he like my 2 lines solution.
            $endgroup$
            – muescha
            Jun 25 '17 at 15:48










          • $begingroup$
            Yeah sorry, I was looking for a Swift 3 solution
            $endgroup$
            – richy
            Jun 25 '17 at 19:08










          • $begingroup$
            @richy then you can use this extension for swift3 to have a groupby in Swift 3: stackoverflow.com/a/31220067/1930509
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53










          • $begingroup$
            with this a later upgrade to swift 4 is easy :)
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53














          • 1




            $begingroup$
            This is specifically tagged swift3...
            $endgroup$
            – Mr. Xcoder
            Jun 25 '17 at 10:47










          • $begingroup$
            There existing some collection extension for grouping by for swift3 if he like my 2 lines solution.
            $endgroup$
            – muescha
            Jun 25 '17 at 15:48










          • $begingroup$
            Yeah sorry, I was looking for a Swift 3 solution
            $endgroup$
            – richy
            Jun 25 '17 at 19:08










          • $begingroup$
            @richy then you can use this extension for swift3 to have a groupby in Swift 3: stackoverflow.com/a/31220067/1930509
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53










          • $begingroup$
            with this a later upgrade to swift 4 is easy :)
            $endgroup$
            – muescha
            Jun 26 '17 at 15:53








          1




          1




          $begingroup$
          This is specifically tagged swift3...
          $endgroup$
          – Mr. Xcoder
          Jun 25 '17 at 10:47




          $begingroup$
          This is specifically tagged swift3...
          $endgroup$
          – Mr. Xcoder
          Jun 25 '17 at 10:47












          $begingroup$
          There existing some collection extension for grouping by for swift3 if he like my 2 lines solution.
          $endgroup$
          – muescha
          Jun 25 '17 at 15:48




          $begingroup$
          There existing some collection extension for grouping by for swift3 if he like my 2 lines solution.
          $endgroup$
          – muescha
          Jun 25 '17 at 15:48












          $begingroup$
          Yeah sorry, I was looking for a Swift 3 solution
          $endgroup$
          – richy
          Jun 25 '17 at 19:08




          $begingroup$
          Yeah sorry, I was looking for a Swift 3 solution
          $endgroup$
          – richy
          Jun 25 '17 at 19:08












          $begingroup$
          @richy then you can use this extension for swift3 to have a groupby in Swift 3: stackoverflow.com/a/31220067/1930509
          $endgroup$
          – muescha
          Jun 26 '17 at 15:53




          $begingroup$
          @richy then you can use this extension for swift3 to have a groupby in Swift 3: stackoverflow.com/a/31220067/1930509
          $endgroup$
          – muescha
          Jun 26 '17 at 15:53












          $begingroup$
          with this a later upgrade to swift 4 is easy :)
          $endgroup$
          – muescha
          Jun 26 '17 at 15:53




          $begingroup$
          with this a later upgrade to swift 4 is easy :)
          $endgroup$
          – muescha
          Jun 26 '17 at 15:53


















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f166367%2fgrouping-models-without-dictionary%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Fairchild Swearingen Metro Inhaltsverzeichnis Geschichte | Innenausstattung | Nutzung | Zwischenfälle...

          Pilgersdorf Inhaltsverzeichnis Geografie | Geschichte | Bevölkerungsentwicklung | Politik | Kultur...

          Marineschifffahrtleitung Inhaltsverzeichnis Geschichte | Heutige Organisation der NATO | Nationale und...