Python, Rock, Paper, Scissor [Better code help] Announcing the arrival of Valued Associate...
Is there any way for the UK Prime Minister to make a motion directly dependent on Government confidence?
representation of vector and matrix in latex
Why didn't Eitri join the fight?
What are the out-of-universe reasons for the references to Toby Maguire-era Spider-Man in ITSV
Has negative voting ever been officially implemented in elections, or seriously proposed, or even studied?
Is it a good idea to use CNN to classify 1D signal?
What is homebrew?
How to tell that you are a giant?
Is it common practice to audition new musicians 1-2-1 before rehearsing with the entire band?
What does the "x" in "x86" represent?
Can a party unilaterally change candidates in preparation for a General election?
An adverb for when you're not exaggerating
Delete nth line from bottom
Closed form of recurrent arithmetic series summation
Is it ethical to give a final exam after the professor has quit before teaching the remaining chapters of the course?
Is there a kind of relay only consumes power when switching?
Around usage results
What is the longest distance a player character can jump in one leap?
Is "Reachable Object" really an NP-complete problem?
Why are the trig functions versine, haversine, exsecant, etc, rarely used in modern mathematics?
また usage in a dictionary
Why wasn't DOSKEY integrated with COMMAND.COM?
Significance of Cersei's obsession with elephants?
2001: A Space Odyssey's use of the song "Daisy Bell" (Bicycle Built for Two); life imitates art or vice-versa?
Python, Rock, Paper, Scissor [Better code help]
Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}
$begingroup$
ecently i wanted to test my python knowledge so im taking these challenges, i came across a Rock paper Scissor challenge and i wanted to make it with less code and reuse the same code over and over. The code below is what i have written so far and it works great, i just want to get your opinions, what can i do better? PS: this is not done.
rules = {
'rock': {
'scissor': 'smashes'
},
'paper': {
'rock': 'packs'
},
'scissor': {
'paper': 'cuts'
}
}
player_one = input("P1 | Rock, Paper or Scissor: ").lower()
player_two = input("P2 | Rock, Paper or Scissor: ").lower()
def play(p1, p2):
if p1 in rules:
if p2 in rules[p1]:
print("{} {} {}".format(p1, rules[p1][p2], p2))
if p2 in rules:
if p1 in rules[p2]:
print("{} {} {}".format(p2, rules[p2][p1], p1))
if p1 not in rules or p2 not in rules:
print("Invalid input")
if __name__ == '__main__':
play(player_one, player_two)
python
asked 46 secs ago
Johnny NiklassonJohnny Niklasson
1
New contributor
Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
ecently i wanted to test my python knowledge so im taking these challenges, i came across a Rock paper Scissor challenge and i wanted to make it with less code and reuse the same code over and over. The code below is what i have written so far and it works great, i just want to get your opinions, what can i do better? PS: this is not done.
rules = {
'rock': {
'scissor': 'smashes'
},
'paper': {
'rock': 'packs'
},
'scissor': {
'paper': 'cuts'
}
}
player_one = input("P1 | Rock, Paper or Scissor: ").lower()
player_two = input("P2 | Rock, Paper or Scissor: ").lower()
def play(p1, p2):
if p1 in rules:
if p2 in rules[p1]:
print("{} {} {}".format(p1, rules[p1][p2], p2))
if p2 in rules:
if p1 in rules[p2]:
print("{} {} {}".format(p2, rules[p2][p1], p1))
if p1 not in rules or p2 not in rules:
print("Invalid input")
if __name__ == '__main__':
play(player_one, player_two)
python
asked 46 secs ago
Johnny NiklassonJohnny Niklasson
1
New contributor
Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
ecently i wanted to test my python knowledge so im taking these challenges, i came across a Rock paper Scissor challenge and i wanted to make it with less code and reuse the same code over and over. The code below is what i have written so far and it works great, i just want to get your opinions, what can i do better? PS: this is not done.
rules = {
'rock': {
'scissor': 'smashes'
},
'paper': {
'rock': 'packs'
},
'scissor': {
'paper': 'cuts'
}
}
player_one = input("P1 | Rock, Paper or Scissor: ").lower()
player_two = input("P2 | Rock, Paper or Scissor: ").lower()
def play(p1, p2):
if p1 in rules:
if p2 in rules[p1]:
print("{} {} {}".format(p1, rules[p1][p2], p2))
if p2 in rules:
if p1 in rules[p2]:
print("{} {} {}".format(p2, rules[p2][p1], p1))
if p1 not in rules or p2 not in rules:
print("Invalid input")
if __name__ == '__main__':
play(player_one, player_two)
python
asked 46 secs ago
Johnny NiklassonJohnny Niklasson
1
New contributor
Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
ecently i wanted to test my python knowledge so im taking these challenges, i came across a Rock paper Scissor challenge and i wanted to make it with less code and reuse the same code over and over. The code below is what i have written so far and it works great, i just want to get your opinions, what can i do better? PS: this is not done.
rules = {
'rock': {
'scissor': 'smashes'
},
'paper': {
'rock': 'packs'
},
'scissor': {
'paper': 'cuts'
}
}
player_one = input("P1 | Rock, Paper or Scissor: ").lower()
player_two = input("P2 | Rock, Paper or Scissor: ").lower()
def play(p1, p2):
if p1 in rules:
if p2 in rules[p1]:
print("{} {} {}".format(p1, rules[p1][p2], p2))
if p2 in rules:
if p1 in rules[p2]:
print("{} {} {}".format(p2, rules[p2][p1], p1))
if p1 not in rules or p2 not in rules:
print("Invalid input")
if __name__ == '__main__':
play(player_one, player_two)
python
python
asked 46 secs ago
Johnny NiklassonJohnny Niklasson
1
New contributor
Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 46 secs ago
Johnny NiklassonJohnny Niklasson
1
New contributor
Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 46 secs ago
Johnny NiklassonJohnny Niklasson
1
New contributor
Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 46 secs ago
Johnny NiklassonJohnny Niklasson
1
asked 46 secs ago
Johnny NiklassonJohnny Niklasson
1
1
New contributor
Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217645%2fpython-rock-paper-scissor-better-code-help%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.
Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.
Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.
Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217645%2fpython-rock-paper-scissor-better-code-help%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
