Making code more flexibleMake this C# code more DRYIn need of some aid in regards to making my code more...
Hostile work environment after whistle-blowing on coworker and our boss. What do I do?
Is there any reason not to eat food that's been dropped on the surface of the moon?
Was the picture area of a CRT a parallelogram (instead of a true rectangle)?
Teaching indefinite integrals that require special-casing
What are the ramifications of creating a homebrew world without an Astral Plane?
How could Frankenstein get the parts for his _second_ creature?
Go Pregnant or Go Home
What is the oldest known work of fiction?
Curses work by shouting - How to avoid collateral damage?
Lay out the Carpet
What is the opposite of 'gravitas'?
Why Were Madagascar and New Zealand Discovered So Late?
Why did Kant, Hegel, and Adorno leave some words and phrases in the Greek alphabet?
Using parameter substitution on a Bash array
Hide Select Output from T-SQL
Student evaluations of teaching assistants
How to verify if g is a generator for p?
Everything Bob says is false. How does he get people to trust him?
Implement the Thanos sorting algorithm
How will losing mobility of one hand affect my career as a programmer?
Products and sum of cubes in Fibonacci
How do I rename a LINUX host without needing to reboot for the rename to take effect?
Do I need a multiple entry visa for a trip UK -> Sweden -> UK?
Is there an Impartial Brexit Deal comparison site?
Making code more flexible
Make this C# code more DRYIn need of some aid in regards to making my code more efficientHow can I make this piece of code more secure?Making adding to a dictionary more efficient?FormBuilder Code Make More GenereicMaking operations more dynamicFlexible socket frameworkMaking generic code when using large EnumsFlexible TCP socket frameworkMaking TypeNameHandling in json.net more convenient
$begingroup$
Basically, I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.
P.S. The vendorCrud object is a database helper.
private List<string> GetVendorInformation(string vendorId)
{
crud vendorCrud = new crud();
List<string> columnData = new List<string>();
string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
"LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
"WHERE vendor.vendor_id = {0} ORDER BY contact_default DESC LIMIT 1", vendorId);
vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);
foreach (DataRow item in vendorCrud.table.Rows)
{
columnData.Add(item["tin"].ToString());
columnData.Add(item["email_add"].ToString());
columnData.Add(item["fax_no"].ToString());
columnData.Add(item["tel_no"].ToString());
columnData.Add(item["contact_person"].ToString());
}
return columnData;
}
private void SetVendorInformation(List<string> colData)
{
txtVendorTin.EditValue = colData[0];
txtEmail.EditValue = colData[1];
txtFaxNo.EditValue = colData[2];
txtTelNo.EditValue = colData[3];
txtAttention.EditValue = colData[4];
}
private void txtSupplier_EditValueChanged(object sender, EventArgs e)
{
SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));
}
c# mysql
asked 7 mins ago
Vish GuerreroVish Guerrero
11
New contributor
Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Basically, I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.
P.S. The vendorCrud object is a database helper.
private List<string> GetVendorInformation(string vendorId)
{
crud vendorCrud = new crud();
List<string> columnData = new List<string>();
string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
"LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
"WHERE vendor.vendor_id = {0} ORDER BY contact_default DESC LIMIT 1", vendorId);
vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);
foreach (DataRow item in vendorCrud.table.Rows)
{
columnData.Add(item["tin"].ToString());
columnData.Add(item["email_add"].ToString());
columnData.Add(item["fax_no"].ToString());
columnData.Add(item["tel_no"].ToString());
columnData.Add(item["contact_person"].ToString());
}
return columnData;
}
private void SetVendorInformation(List<string> colData)
{
txtVendorTin.EditValue = colData[0];
txtEmail.EditValue = colData[1];
txtFaxNo.EditValue = colData[2];
txtTelNo.EditValue = colData[3];
txtAttention.EditValue = colData[4];
}
private void txtSupplier_EditValueChanged(object sender, EventArgs e)
{
SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));
}
c# mysql
asked 7 mins ago
Vish GuerreroVish Guerrero
11
New contributor
Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Basically, I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.
P.S. The vendorCrud object is a database helper.
private List<string> GetVendorInformation(string vendorId)
{
crud vendorCrud = new crud();
List<string> columnData = new List<string>();
string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
"LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
"WHERE vendor.vendor_id = {0} ORDER BY contact_default DESC LIMIT 1", vendorId);
vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);
foreach (DataRow item in vendorCrud.table.Rows)
{
columnData.Add(item["tin"].ToString());
columnData.Add(item["email_add"].ToString());
columnData.Add(item["fax_no"].ToString());
columnData.Add(item["tel_no"].ToString());
columnData.Add(item["contact_person"].ToString());
}
return columnData;
}
private void SetVendorInformation(List<string> colData)
{
txtVendorTin.EditValue = colData[0];
txtEmail.EditValue = colData[1];
txtFaxNo.EditValue = colData[2];
txtTelNo.EditValue = colData[3];
txtAttention.EditValue = colData[4];
}
private void txtSupplier_EditValueChanged(object sender, EventArgs e)
{
SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));
}
c# mysql
asked 7 mins ago
Vish GuerreroVish Guerrero
11
New contributor
Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
Basically, I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.
P.S. The vendorCrud object is a database helper.
private List<string> GetVendorInformation(string vendorId)
{
crud vendorCrud = new crud();
List<string> columnData = new List<string>();
string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
"LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
"WHERE vendor.vendor_id = {0} ORDER BY contact_default DESC LIMIT 1", vendorId);
vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);
foreach (DataRow item in vendorCrud.table.Rows)
{
columnData.Add(item["tin"].ToString());
columnData.Add(item["email_add"].ToString());
columnData.Add(item["fax_no"].ToString());
columnData.Add(item["tel_no"].ToString());
columnData.Add(item["contact_person"].ToString());
}
return columnData;
}
private void SetVendorInformation(List<string> colData)
{
txtVendorTin.EditValue = colData[0];
txtEmail.EditValue = colData[1];
txtFaxNo.EditValue = colData[2];
txtTelNo.EditValue = colData[3];
txtAttention.EditValue = colData[4];
}
private void txtSupplier_EditValueChanged(object sender, EventArgs e)
{
SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));
}
c# mysql
c# mysql
asked 7 mins ago
Vish GuerreroVish Guerrero
11
New contributor
Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
Vish GuerreroVish Guerrero
11
New contributor
Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
Vish GuerreroVish Guerrero
11
New contributor
Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
Vish GuerreroVish Guerrero
11
asked 7 mins ago
Vish GuerreroVish Guerrero
11
11
New contributor
Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216306%2fmaking-code-more-flexible%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.
Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.
Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.
Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216306%2fmaking-code-more-flexible%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
