Retrieving information about a vendor using MySQLMake this C# code more DRYIn need of some aid in regards to...

Can I use my Chinese passport to enter China after I acquired another citizenship?

Curses work by shouting - How to avoid collateral damage?

Lay out the Carpet

Valid Badminton Score?

What would happen if the UK refused to take part in EU Parliamentary elections?

Was the picture area of a CRT a parallelogram (instead of a true rectangle)?

Can a monster with multiattack use this ability if they are missing a limb?

If you attempt to grapple an opponent that you are hidden from, do they roll at disadvantage?

Can I Retrieve Email Addresses from BCC?

Is exact Kanji stroke length important?

How will losing mobility of one hand affect my career as a programmer?

At which point does a character regain all their Hit Dice?

How can I replace every global instance of "x[2]" with "x_2"

How can I use the arrow sign in my bash prompt?

Opposite of a diet

How do I rename a LINUX host without needing to reboot for the rename to take effect?

There is only s̶i̶x̶t̶y one place he can be

Is there any easy technique written in Bhagavad GITA to control lust?

Hide Select Output from T-SQL

Using parameter substitution on a Bash array

Finding all intervals that match predicate in vector

The baby cries all morning

Should my PhD thesis be submitted under my legal name?

Student evaluations of teaching assistants



Retrieving information about a vendor using MySQL


Make this C# code more DRYIn need of some aid in regards to making my code more efficientHow can I make this piece of code more secure?Making adding to a dictionary more efficient?FormBuilder Code Make More GenereicMaking operations more dynamicFlexible socket frameworkMaking generic code when using large EnumsFlexible TCP socket frameworkMaking TypeNameHandling in json.net more convenient













0












$begingroup$


I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.



P.S. The vendorCrud object is a database helper.



 private List<string> GetVendorInformation(string vendorId)
{
crud vendorCrud = new crud();
List<string> columnData = new List<string>();

string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
"LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
"WHERE vendor.vendor_id = {0} ORDER BY contact_default DESC LIMIT 1", vendorId);

vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);

foreach (DataRow item in vendorCrud.table.Rows)
{
columnData.Add(item["tin"].ToString());
columnData.Add(item["email_add"].ToString());
columnData.Add(item["fax_no"].ToString());
columnData.Add(item["tel_no"].ToString());
columnData.Add(item["contact_person"].ToString());
}

return columnData;
}

private void SetVendorInformation(List<string> colData)
{
txtVendorTin.EditValue = colData[0];
txtEmail.EditValue = colData[1];
txtFaxNo.EditValue = colData[2];
txtTelNo.EditValue = colData[3];
txtAttention.EditValue = colData[4];
}

private void txtSupplier_EditValueChanged(object sender, EventArgs e)
{
SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));
}









share|improve this question









New contributor




Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.



    P.S. The vendorCrud object is a database helper.



     private List<string> GetVendorInformation(string vendorId)
    {
    crud vendorCrud = new crud();
    List<string> columnData = new List<string>();

    string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
    "LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
    "WHERE vendor.vendor_id = {0} ORDER BY contact_default DESC LIMIT 1", vendorId);

    vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);

    foreach (DataRow item in vendorCrud.table.Rows)
    {
    columnData.Add(item["tin"].ToString());
    columnData.Add(item["email_add"].ToString());
    columnData.Add(item["fax_no"].ToString());
    columnData.Add(item["tel_no"].ToString());
    columnData.Add(item["contact_person"].ToString());
    }

    return columnData;
    }

    private void SetVendorInformation(List<string> colData)
    {
    txtVendorTin.EditValue = colData[0];
    txtEmail.EditValue = colData[1];
    txtFaxNo.EditValue = colData[2];
    txtTelNo.EditValue = colData[3];
    txtAttention.EditValue = colData[4];
    }

    private void txtSupplier_EditValueChanged(object sender, EventArgs e)
    {
    SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));
    }









    share|improve this question









    New contributor




    Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.



      P.S. The vendorCrud object is a database helper.



       private List<string> GetVendorInformation(string vendorId)
      {
      crud vendorCrud = new crud();
      List<string> columnData = new List<string>();

      string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
      "LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
      "WHERE vendor.vendor_id = {0} ORDER BY contact_default DESC LIMIT 1", vendorId);

      vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);

      foreach (DataRow item in vendorCrud.table.Rows)
      {
      columnData.Add(item["tin"].ToString());
      columnData.Add(item["email_add"].ToString());
      columnData.Add(item["fax_no"].ToString());
      columnData.Add(item["tel_no"].ToString());
      columnData.Add(item["contact_person"].ToString());
      }

      return columnData;
      }

      private void SetVendorInformation(List<string> colData)
      {
      txtVendorTin.EditValue = colData[0];
      txtEmail.EditValue = colData[1];
      txtFaxNo.EditValue = colData[2];
      txtTelNo.EditValue = colData[3];
      txtAttention.EditValue = colData[4];
      }

      private void txtSupplier_EditValueChanged(object sender, EventArgs e)
      {
      SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));
      }









      share|improve this question









      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.



      P.S. The vendorCrud object is a database helper.



       private List<string> GetVendorInformation(string vendorId)
      {
      crud vendorCrud = new crud();
      List<string> columnData = new List<string>();

      string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
      "LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
      "WHERE vendor.vendor_id = {0} ORDER BY contact_default DESC LIMIT 1", vendorId);

      vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);

      foreach (DataRow item in vendorCrud.table.Rows)
      {
      columnData.Add(item["tin"].ToString());
      columnData.Add(item["email_add"].ToString());
      columnData.Add(item["fax_no"].ToString());
      columnData.Add(item["tel_no"].ToString());
      columnData.Add(item["contact_person"].ToString());
      }

      return columnData;
      }

      private void SetVendorInformation(List<string> colData)
      {
      txtVendorTin.EditValue = colData[0];
      txtEmail.EditValue = colData[1];
      txtFaxNo.EditValue = colData[2];
      txtTelNo.EditValue = colData[3];
      txtAttention.EditValue = colData[4];
      }

      private void txtSupplier_EditValueChanged(object sender, EventArgs e)
      {
      SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));
      }






      c# mysql






      share|improve this question









      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 4 mins ago









      200_success

      130k17155419




      130k17155419






      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 46 mins ago









      Vish GuerreroVish Guerrero

      12




      12




      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216306%2fretrieving-information-about-a-vendor-using-mysql%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.













          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.












          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216306%2fretrieving-information-about-a-vendor-using-mysql%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          is 'sed' thread safeWhat should someone know about using Python scripts in the shell?Nexenta bash script uses...

          How do i solve the “ No module named 'mlxtend' ” issue on Jupyter?

          Pilgersdorf Inhaltsverzeichnis Geografie | Geschichte | Bevölkerungsentwicklung | Politik | Kultur...