java Thread-safe LRUCache implementationImplementing a shared array cache without lockingTime Sensitive...

Where is the License file location for Identity Server in Sitecore 9.1?

How spaceships determine each other's mass in space?

What is Tony Stark injecting into himself in Iron Man 3?

School performs periodic password audits. Is my password compromised?

Generating a list with duplicate entries

PTIJ: Sport in the Torah

Are small insurances worth it?

What does it take to become a wilderness skills guide as a business?

Why aren't there more Gauls like Obelix?

What is better: yes / no radio, or simple checkbox?

How do you make a gun that shoots melee weapons and/or swords?

Short SF story. Females use stingers to implant eggs in yearfathers

What is the orbit and expected lifetime of Crew Dragon trunk?

Is there a math expression equivalent to the conditional ternary operator?

Create chunks from an array

Ultrafilters as a double dual

A vote on the Brexit backstop

How do you use environments that have the same name within a single latex document?

Rationale to prefer local variables over instance variables?

Should I apply for my boss's promotion?

Averaging over columns while ignoring zero entries

Sort array by month and year

Why do we call complex numbers “numbers” but we don’t consider 2-vectors numbers?

How to write a chaotic neutral protagonist and prevent my readers from thinking they are evil?



java Thread-safe LRUCache implementation


Implementing a shared array cache without lockingTime Sensitive ConcurrentDictionaryThread-safe LRU cache for C++Using Concurrent Dictionary and Lazy<T> to cache expensive query results and only run query once in a threadsafe mannerModel for starting a thread with an initial value, pausing, resuming with a new value and stopping a threadA multi-threaded key-value cache that only has thread contention while querying for same key simultaneouslyLRU cache implementationLRU Cache in constant timeLeetcode #146. LRUCache solution in Java (Doubly Linked List + HashMap)Concurrent observable collection













0












$begingroup$


What is best way to implement thread-safe LRUCache in java?
Please review this one.
Is there any better approach which can be taken here?



package cache;

import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock;

public class LRUCache<K,V> {

private ConcurrentLinkedQueue<K> concurrentLinkedQueue = new ConcurrentLinkedQueue<K>();

private ConcurrentHashMap<K,V> concurrentHashMap = new ConcurrentHashMap<K, V>();

private ReadWriteLock readWriteLock = new ReentrantReadWriteLock();

private Lock readLock = readWriteLock.readLock();

private Lock writeLock = readWriteLock.writeLock();

int maxSize=0;

public LRUCache(final int MAX_SIZE){
this.maxSize=MAX_SIZE;
}

public V getElement(K key){

readLock.lock();
try {
V v=null;
if(concurrentHashMap.contains(key)){
concurrentLinkedQueue.remove(key);
v= concurrentHashMap.get(key);
concurrentLinkedQueue.add(key);
}


return v;
}finally{
readLock.unlock();
}
}

public V removeElement(K key){
writeLock.lock();
try {
V v=null;
if(concurrentHashMap.contains(key)){
v=concurrentHashMap.remove(key);
concurrentLinkedQueue.remove(key);
}

return v;
} finally {
writeLock.unlock();
}
}

public V addElement(K key,V value){
writeLock.lock();
try {
if(concurrentHashMap.contains(key)){
concurrentLinkedQueue.remove(key);
}
while(concurrentLinkedQueue.size() >=maxSize){
K queueKey=concurrentLinkedQueue.poll();
concurrentHashMap.remove(queueKey);
}
concurrentLinkedQueue.add(key);
concurrentHashMap.put(key, value);

return value;
} finally{
writeLock.unlock();
}
}
}








share







New contributor




AKS is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    What is best way to implement thread-safe LRUCache in java?
    Please review this one.
    Is there any better approach which can be taken here?



    package cache;

    import java.util.concurrent.ConcurrentHashMap;
    import java.util.concurrent.ConcurrentLinkedQueue;
    import java.util.concurrent.locks.Lock;
    import java.util.concurrent.locks.ReadWriteLock;
    import java.util.concurrent.locks.ReentrantReadWriteLock;

    public class LRUCache<K,V> {

    private ConcurrentLinkedQueue<K> concurrentLinkedQueue = new ConcurrentLinkedQueue<K>();

    private ConcurrentHashMap<K,V> concurrentHashMap = new ConcurrentHashMap<K, V>();

    private ReadWriteLock readWriteLock = new ReentrantReadWriteLock();

    private Lock readLock = readWriteLock.readLock();

    private Lock writeLock = readWriteLock.writeLock();

    int maxSize=0;

    public LRUCache(final int MAX_SIZE){
    this.maxSize=MAX_SIZE;
    }

    public V getElement(K key){

    readLock.lock();
    try {
    V v=null;
    if(concurrentHashMap.contains(key)){
    concurrentLinkedQueue.remove(key);
    v= concurrentHashMap.get(key);
    concurrentLinkedQueue.add(key);
    }


    return v;
    }finally{
    readLock.unlock();
    }
    }

    public V removeElement(K key){
    writeLock.lock();
    try {
    V v=null;
    if(concurrentHashMap.contains(key)){
    v=concurrentHashMap.remove(key);
    concurrentLinkedQueue.remove(key);
    }

    return v;
    } finally {
    writeLock.unlock();
    }
    }

    public V addElement(K key,V value){
    writeLock.lock();
    try {
    if(concurrentHashMap.contains(key)){
    concurrentLinkedQueue.remove(key);
    }
    while(concurrentLinkedQueue.size() >=maxSize){
    K queueKey=concurrentLinkedQueue.poll();
    concurrentHashMap.remove(queueKey);
    }
    concurrentLinkedQueue.add(key);
    concurrentHashMap.put(key, value);

    return value;
    } finally{
    writeLock.unlock();
    }
    }
    }








    share







    New contributor




    AKS is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      What is best way to implement thread-safe LRUCache in java?
      Please review this one.
      Is there any better approach which can be taken here?



      package cache;

      import java.util.concurrent.ConcurrentHashMap;
      import java.util.concurrent.ConcurrentLinkedQueue;
      import java.util.concurrent.locks.Lock;
      import java.util.concurrent.locks.ReadWriteLock;
      import java.util.concurrent.locks.ReentrantReadWriteLock;

      public class LRUCache<K,V> {

      private ConcurrentLinkedQueue<K> concurrentLinkedQueue = new ConcurrentLinkedQueue<K>();

      private ConcurrentHashMap<K,V> concurrentHashMap = new ConcurrentHashMap<K, V>();

      private ReadWriteLock readWriteLock = new ReentrantReadWriteLock();

      private Lock readLock = readWriteLock.readLock();

      private Lock writeLock = readWriteLock.writeLock();

      int maxSize=0;

      public LRUCache(final int MAX_SIZE){
      this.maxSize=MAX_SIZE;
      }

      public V getElement(K key){

      readLock.lock();
      try {
      V v=null;
      if(concurrentHashMap.contains(key)){
      concurrentLinkedQueue.remove(key);
      v= concurrentHashMap.get(key);
      concurrentLinkedQueue.add(key);
      }


      return v;
      }finally{
      readLock.unlock();
      }
      }

      public V removeElement(K key){
      writeLock.lock();
      try {
      V v=null;
      if(concurrentHashMap.contains(key)){
      v=concurrentHashMap.remove(key);
      concurrentLinkedQueue.remove(key);
      }

      return v;
      } finally {
      writeLock.unlock();
      }
      }

      public V addElement(K key,V value){
      writeLock.lock();
      try {
      if(concurrentHashMap.contains(key)){
      concurrentLinkedQueue.remove(key);
      }
      while(concurrentLinkedQueue.size() >=maxSize){
      K queueKey=concurrentLinkedQueue.poll();
      concurrentHashMap.remove(queueKey);
      }
      concurrentLinkedQueue.add(key);
      concurrentHashMap.put(key, value);

      return value;
      } finally{
      writeLock.unlock();
      }
      }
      }








      share







      New contributor




      AKS is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      What is best way to implement thread-safe LRUCache in java?
      Please review this one.
      Is there any better approach which can be taken here?



      package cache;

      import java.util.concurrent.ConcurrentHashMap;
      import java.util.concurrent.ConcurrentLinkedQueue;
      import java.util.concurrent.locks.Lock;
      import java.util.concurrent.locks.ReadWriteLock;
      import java.util.concurrent.locks.ReentrantReadWriteLock;

      public class LRUCache<K,V> {

      private ConcurrentLinkedQueue<K> concurrentLinkedQueue = new ConcurrentLinkedQueue<K>();

      private ConcurrentHashMap<K,V> concurrentHashMap = new ConcurrentHashMap<K, V>();

      private ReadWriteLock readWriteLock = new ReentrantReadWriteLock();

      private Lock readLock = readWriteLock.readLock();

      private Lock writeLock = readWriteLock.writeLock();

      int maxSize=0;

      public LRUCache(final int MAX_SIZE){
      this.maxSize=MAX_SIZE;
      }

      public V getElement(K key){

      readLock.lock();
      try {
      V v=null;
      if(concurrentHashMap.contains(key)){
      concurrentLinkedQueue.remove(key);
      v= concurrentHashMap.get(key);
      concurrentLinkedQueue.add(key);
      }


      return v;
      }finally{
      readLock.unlock();
      }
      }

      public V removeElement(K key){
      writeLock.lock();
      try {
      V v=null;
      if(concurrentHashMap.contains(key)){
      v=concurrentHashMap.remove(key);
      concurrentLinkedQueue.remove(key);
      }

      return v;
      } finally {
      writeLock.unlock();
      }
      }

      public V addElement(K key,V value){
      writeLock.lock();
      try {
      if(concurrentHashMap.contains(key)){
      concurrentLinkedQueue.remove(key);
      }
      while(concurrentLinkedQueue.size() >=maxSize){
      K queueKey=concurrentLinkedQueue.poll();
      concurrentHashMap.remove(queueKey);
      }
      concurrentLinkedQueue.add(key);
      concurrentHashMap.put(key, value);

      return value;
      } finally{
      writeLock.unlock();
      }
      }
      }






      java multithreading concurrency cache





      share







      New contributor




      AKS is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      AKS is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      AKS is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 5 mins ago









      AKSAKS

      101




      101




      New contributor




      AKS is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      AKS is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      AKS is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          AKS is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215075%2fjava-thread-safe-lrucache-implementation%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          AKS is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          AKS is a new contributor. Be nice, and check out our Code of Conduct.













          AKS is a new contributor. Be nice, and check out our Code of Conduct.












          AKS is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215075%2fjava-thread-safe-lrucache-implementation%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Fairchild Swearingen Metro Inhaltsverzeichnis Geschichte | Innenausstattung | Nutzung | Zwischenfälle...

          Pilgersdorf Inhaltsverzeichnis Geografie | Geschichte | Bevölkerungsentwicklung | Politik | Kultur...

          Marineschifffahrtleitung Inhaltsverzeichnis Geschichte | Heutige Organisation der NATO | Nationale und...