Python Password Brute-Forcer The 2019 Stack Overflow Developer Survey Results Are In ...

Why doesn't a hydraulic lever violate conservation of energy?

should truth entail possible truth

Why are PDP-7-style microprogrammed instructions out of vogue?

"is" operation returns false even though two objects have same id

Sort list of array linked objects by keys and values

Do working physicists consider Newtonian mechanics to be "falsified"?

What force causes entropy to increase?

Visa regaring travelling European country

Circular reasoning in L'Hopital's rule

How to politely respond to generic emails requesting a PhD/job in my lab? Without wasting too much time

US Healthcare consultation for visitors

For what reasons would an animal species NOT cross a *horizontal* land bridge?

What information about me do stores get via my credit card?

What is the padding with red substance inside of steak packaging?

Can withdrawing asylum be illegal?

Does Parliament hold absolute power in the UK?

Why not take a picture of a closer black hole?

How did passengers keep warm on sail ships?

Didn't get enough time to take a Coding Test - what to do now?

How do you keep chess fun when your opponent constantly beats you?

What happens to a Warlock's expended Spell Slots when they gain a Level?

Am I ethically obligated to go into work on an off day if the reason is sudden?

Is this wall load bearing? Blueprints and photos attached

First use of “packing” as in carrying a gun

Python Password Brute-Forcer

The 2019 Stack Overflow Developer Survey Results Are In

Unicorn Meta Zoo #1: Why another podcast?

Announcing the arrival of Valued Associate #679: Cesar ManaraBrute force HTTP with PythonPython small brute-forcerBrute force script for printing a passwordPassword Validation in PythonRandom password cracker using brute forceThe BFS approach to the SmartWordToy challengePassword Checker in PythonPython - username and password authenticationPython password generatorBrute force password cracker in Python

.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}

I'm working on a password brute-forcer that takes in a password from the user and brute-forces solutions until it finds a match. I was wondering if there is any way to improve performance or readability?

import itertools

import time



Alphabet = ("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXiuYZ1234567890-_.")



Password = input("What is your password?n")



start = time.time()



counter = 1



CharLength = 1



for CharLength in range(25):



    passwords = (itertools.product(Alphabet, repeat = CharLength))



    print("n")



    print("Currently working on passwords with ", CharLength, " characters.")

    print("We are currently at ", (counter / (time.time() - start)), "attempts per second.")

    print("It has been ", time.time() - start, " seconds.")

    print("We have tried ", counter, " possible passwords.")



    for i in passwords:



        counter += 1



        i = str(i)



        i = i.replace("[", "")

        i = i.replace("]", "")

        i = i.replace("'", "")

        i = i.replace(" ", "")

        i = i.replace(",", "")

        i = i.replace("(", "")

        i = i.replace(")", "")



        if i == Password:



            end = time.time()



            timetaken = end - start



            print("nPassword found in ", timetaken, " seconds and ", counter, "attempts.")



            print("That is ", counter / timetaken, " attempts per second.")



            print("nThe password is "%s"." % i)



            input("nPress enter when you have finished.")



            exit()

Thanks.

edited Oct 14 '18 at 15:18

Gerrit0

3,1081624

asked Oct 14 '18 at 15:05

Michael O'Connell

bumped to the homepage by Community♦ 22 mins ago

This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.

$begingroup$
What would this code be used for? It asks for the plain text password, not a hash, and just iterates over all possible strings of length 0 through 24 until it matches what it already knows.
$endgroup$
– l0b0
Oct 15 '18 at 3:02

$begingroup$
@l0b0 I'll later implement some sort of web form functionality.
$endgroup$
– Michael O'Connell
Oct 20 '18 at 19:04

add a comment |

import itertools

import time



Alphabet = ("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXiuYZ1234567890-_.")



Password = input("What is your password?n")



start = time.time()



counter = 1



CharLength = 1



for CharLength in range(25):



    passwords = (itertools.product(Alphabet, repeat = CharLength))



    print("n")



    print("Currently working on passwords with ", CharLength, " characters.")

    print("We are currently at ", (counter / (time.time() - start)), "attempts per second.")

    print("It has been ", time.time() - start, " seconds.")

    print("We have tried ", counter, " possible passwords.")



    for i in passwords:



        counter += 1



        i = str(i)



        i = i.replace("[", "")

        i = i.replace("]", "")

        i = i.replace("'", "")

        i = i.replace(" ", "")

        i = i.replace(",", "")

        i = i.replace("(", "")

        i = i.replace(")", "")



        if i == Password:



            end = time.time()



            timetaken = end - start



            print("nPassword found in ", timetaken, " seconds and ", counter, "attempts.")



            print("That is ", counter / timetaken, " attempts per second.")



            print("nThe password is "%s"." % i)



            input("nPress enter when you have finished.")



            exit()

Thanks.

edited Oct 14 '18 at 15:18

Gerrit0

3,1081624

asked Oct 14 '18 at 15:05

Michael O'Connell

bumped to the homepage by Community♦ 22 mins ago

This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.

$begingroup$
What would this code be used for? It asks for the plain text password, not a hash, and just iterates over all possible strings of length 0 through 24 until it matches what it already knows.
$endgroup$
– l0b0
Oct 15 '18 at 3:02

$begingroup$
@l0b0 I'll later implement some sort of web form functionality.
$endgroup$
– Michael O'Connell
Oct 20 '18 at 19:04

add a comment |

import itertools

import time



Alphabet = ("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXiuYZ1234567890-_.")



Password = input("What is your password?n")



start = time.time()



counter = 1



CharLength = 1



for CharLength in range(25):



    passwords = (itertools.product(Alphabet, repeat = CharLength))



    print("n")



    print("Currently working on passwords with ", CharLength, " characters.")

    print("We are currently at ", (counter / (time.time() - start)), "attempts per second.")

    print("It has been ", time.time() - start, " seconds.")

    print("We have tried ", counter, " possible passwords.")



    for i in passwords:



        counter += 1



        i = str(i)



        i = i.replace("[", "")

        i = i.replace("]", "")

        i = i.replace("'", "")

        i = i.replace(" ", "")

        i = i.replace(",", "")

        i = i.replace("(", "")

        i = i.replace(")", "")



        if i == Password:



            end = time.time()



            timetaken = end - start



            print("nPassword found in ", timetaken, " seconds and ", counter, "attempts.")



            print("That is ", counter / timetaken, " attempts per second.")



            print("nThe password is "%s"." % i)



            input("nPress enter when you have finished.")



            exit()

Thanks.

edited Oct 14 '18 at 15:18

Gerrit0

3,1081624

asked Oct 14 '18 at 15:05

Michael O'Connell

import itertools

import time



Alphabet = ("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXiuYZ1234567890-_.")



Password = input("What is your password?n")



start = time.time()



counter = 1



CharLength = 1



for CharLength in range(25):



    passwords = (itertools.product(Alphabet, repeat = CharLength))



    print("n")



    print("Currently working on passwords with ", CharLength, " characters.")

    print("We are currently at ", (counter / (time.time() - start)), "attempts per second.")

    print("It has been ", time.time() - start, " seconds.")

    print("We have tried ", counter, " possible passwords.")



    for i in passwords:



        counter += 1



        i = str(i)



        i = i.replace("[", "")

        i = i.replace("]", "")

        i = i.replace("'", "")

        i = i.replace(" ", "")

        i = i.replace(",", "")

        i = i.replace("(", "")

        i = i.replace(")", "")



        if i == Password:



            end = time.time()



            timetaken = end - start



            print("nPassword found in ", timetaken, " seconds and ", counter, "attempts.")



            print("That is ", counter / timetaken, " attempts per second.")



            print("nThe password is "%s"." % i)



            input("nPress enter when you have finished.")



            exit()

Thanks.

python

edited Oct 14 '18 at 15:18

Gerrit0

3,1081624

asked Oct 14 '18 at 15:05

Michael O'Connell

edited Oct 14 '18 at 15:18

Gerrit0

3,1081624

asked Oct 14 '18 at 15:05

Michael O'Connell

edited Oct 14 '18 at 15:18

Gerrit0

3,1081624

edited Oct 14 '18 at 15:18

Gerrit0

3,1081624

edited Oct 14 '18 at 15:18

Gerrit0

3,1081624

asked Oct 14 '18 at 15:05

Michael O'Connell

asked Oct 14 '18 at 15:05

Michael O'Connell

asked Oct 14 '18 at 15:05

Michael O'Connell

bumped to the homepage by Community♦ 22 mins ago

This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.

bumped to the homepage by Community♦ 22 mins ago

This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.

$begingroup$
What would this code be used for? It asks for the plain text password, not a hash, and just iterates over all possible strings of length 0 through 24 until it matches what it already knows.
$endgroup$
– l0b0
Oct 15 '18 at 3:02

$begingroup$
@l0b0 I'll later implement some sort of web form functionality.
$endgroup$
– Michael O'Connell
Oct 20 '18 at 19:04

add a comment |

$begingroup$
What would this code be used for? It asks for the plain text password, not a hash, and just iterates over all possible strings of length 0 through 24 until it matches what it already knows.
$endgroup$
– l0b0
Oct 15 '18 at 3:02

$begingroup$
@l0b0 I'll later implement some sort of web form functionality.
$endgroup$
– Michael O'Connell
Oct 20 '18 at 19:04

What would this code be used for? It asks for the plain text password, not a hash, and just iterates over all possible strings of length 0 through 24 until it matches what it already knows.

– l0b0
Oct 15 '18 at 3:02

@l0b0 I'll later implement some sort of web form functionality.

– Michael O'Connell
Oct 20 '18 at 19:04

add a comment |

1 Answer
1

active

oldest

votes

Some recommendations just looking at the style of the code:

It would benefit from being run through pycodestyle, flake8 and/or similar tools to be more idiomatic. This would make the code easier to read for anyone familiar with Python.

Timing code should not be part of your program. External tools like time can handle that.

Use argparse rather than input to make the program scriptable. The script should not stop anywhere to ask for input.

The Alphabet and 25 in this code are good candidates for configuration or parameters.

You can remove all of a list of characters from a string in a single command.

answered Oct 15 '18 at 3:09

l0b0

4,6291023

add a comment |

Your Answer

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});

}
});

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f205544%2fpython-password-brute-forcer%23new-answer', 'question_page');
}
);

Post as a guest

Name

Required, but never shown

1 Answer
1

active

oldest

votes

1 Answer
1

active

oldest

votes

Some recommendations just looking at the style of the code:

It would benefit from being run through pycodestyle, flake8 and/or similar tools to be more idiomatic. This would make the code easier to read for anyone familiar with Python.

Timing code should not be part of your program. External tools like time can handle that.

Use argparse rather than input to make the program scriptable. The script should not stop anywhere to ask for input.

The Alphabet and 25 in this code are good candidates for configuration or parameters.

You can remove all of a list of characters from a string in a single command.

answered Oct 15 '18 at 3:09

l0b0

4,6291023

add a comment |

Some recommendations just looking at the style of the code:

It would benefit from being run through pycodestyle, flake8 and/or similar tools to be more idiomatic. This would make the code easier to read for anyone familiar with Python.

Timing code should not be part of your program. External tools like time can handle that.

Use argparse rather than input to make the program scriptable. The script should not stop anywhere to ask for input.

The Alphabet and 25 in this code are good candidates for configuration or parameters.

You can remove all of a list of characters from a string in a single command.

answered Oct 15 '18 at 3:09

l0b0

4,6291023

add a comment |

Some recommendations just looking at the style of the code:

It would benefit from being run through pycodestyle, flake8 and/or similar tools to be more idiomatic. This would make the code easier to read for anyone familiar with Python.

Timing code should not be part of your program. External tools like time can handle that.

Use argparse rather than input to make the program scriptable. The script should not stop anywhere to ask for input.

The Alphabet and 25 in this code are good candidates for configuration or parameters.

You can remove all of a list of characters from a string in a single command.

answered Oct 15 '18 at 3:09

l0b0

4,6291023

Some recommendations just looking at the style of the code:

It would benefit from being run through pycodestyle, flake8 and/or similar tools to be more idiomatic. This would make the code easier to read for anyone familiar with Python.

Timing code should not be part of your program. External tools like time can handle that.

Use argparse rather than input to make the program scriptable. The script should not stop anywhere to ask for input.

The Alphabet and 25 in this code are good candidates for configuration or parameters.

You can remove all of a list of characters from a string in a single command.

answered Oct 15 '18 at 3:09

l0b0

4,6291023

answered Oct 15 '18 at 3:09

l0b0

4,6291023

answered Oct 15 '18 at 3:09

l0b0

4,6291023

answered Oct 15 '18 at 3:09

l0b0

4,6291023

add a comment |

draft saved

draft discarded

Thanks for contributing an answer to Code Review Stack Exchange!

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

Use MathJax to format equations. MathJax reference.

To learn more, see our tips on writing great answers.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Name

Required, but never shown

Name

Required, but never shown

This page is only for reference, If you need detailed information, please check here

搜尋此網誌

Ggthjy