Turning hourly data for columns of data into daily The 2019 Stack Overflow Developer Survey...
What force causes entropy to increase?
Why doesn't a hydraulic lever violate conservation of energy?
Can the DM override racial traits?
Is 'stolen' appropriate word?
What aspect of planet Earth must be changed to prevent the industrial revolution?
For what reasons would an animal species NOT cross a *horizontal* land bridge?
Is an up-to-date browser secure on an out-of-date OS?
How do you keep chess fun when your opponent constantly beats you?
My body leaves; my core can stay
"is" operation returns false even though two objects have same id
number sequence puzzle deep six
What can I do to 'burn' a journal?
What to do when moving next to a bird sanctuary with a loosely-domesticated cat?
Why doesn't shell automatically fix "useless use of cat"?
Define a list range inside a list
Is it ethical to upload a automatically generated paper to a non peer-reviewed site as part of a larger research?
One-dimensional Japanese puzzle
Is there a writing software that you can sort scenes like slides in PowerPoint?
How to determine omitted units in a publication
Can withdrawing asylum be illegal?
60's-70's movie: home appliances revolting against the owners
What was the last x86 CPU that did not have the x87 floating-point unit built in?
Did the UK government pay "millions and millions of dollars" to try to snag Julian Assange?
Using dividends to reduce short term capital gains?
Turning hourly data for columns of data into daily
The 2019 Stack Overflow Developer Survey Results Are In
Unicorn Meta Zoo #1: Why another podcast?
Announcing the arrival of Valued Associate #679: Cesar ManaraNon-standardised data across multiple worksheets: Aggregation, Validation, FilteringVBA macro which filters and splits dataset into new workbooksForecast maintenance interval for fleet of aircraftConsolidate used student hours into master sheet for exportWorkbook for tracking projectsMaking a report from payroll detailsSum hours worked depending on day typeExcel 'big' data processing with vlookupsExcel 'Big' Data Processing FollowupFastest method of getting the bounding box containing all value ranges
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}
$begingroup$
I've got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made?
Other information:
for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u
is the first cell of the hourly data.
u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1
Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double
ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double
ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double
counter = 0
total_obs_q = 0
For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s
total_obs_q = total_obs_q + obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w
vba excel
New contributor
$endgroup$
add a comment |
$begingroup$
I've got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made?
Other information:
for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u
is the first cell of the hourly data.
u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1
Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double
ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double
ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double
counter = 0
total_obs_q = 0
For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s
total_obs_q = total_obs_q + obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w
vba excel
New contributor
$endgroup$
add a comment |
$begingroup$
I've got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made?
Other information:
for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u
is the first cell of the hourly data.
u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1
Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double
ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double
ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double
counter = 0
total_obs_q = 0
For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s
total_obs_q = total_obs_q + obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w
vba excel
New contributor
$endgroup$
I've got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made?
Other information:
for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u
is the first cell of the hourly data.
u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1
Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double
ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double
ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double
counter = 0
total_obs_q = 0
For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s
total_obs_q = total_obs_q + obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w
vba excel
vba excel
New contributor
New contributor
edited 41 secs ago
Jamal♦
30.6k11121227
30.6k11121227
New contributor
asked 51 mins ago
Josh AltonJosh Alton
1
1
New contributor
New contributor
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217352%2fturning-hourly-data-for-columns-of-data-into-daily%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217352%2fturning-hourly-data-for-columns-of-data-into-daily%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown