Caching different http-requestsC# small caching APIMemcached cachingChaining HTTP requests becoming...

What is the time complexity of enqueue and dequeue of a queue implemented with a singly linked list?

Why are the books in the Game of Thrones citadel library shelved spine inwards?

How to deal with an incendiary email that was recalled

What kind of hardware implements Fourier transform?

Getting a UK passport renewed when you have dual nationality and a different name in your second country?

What's a good word to describe a public place that looks like it wouldn't be rough?

Reference on complex cobordism

How to acknowledge an embarrassing job interview, now that I work directly with the interviewer?

Knowing when to use pictures over words

How to avoid being sexist when trying to employ someone to function in a very sexist environment?

What is better: yes / no radio, or simple checkbox?

Unwarranted claim of higher degree of accuracy in zircon geochronology

Is it a fallacy if someone claims they need an explanation for every word of your argument to the point where they don't understand common terms?

En Passant For Beginners

Why did Jodrell Bank assist the Soviet Union to collect data from their spacecraft in the mid 1960's?

Can polymorphing monsters spam their ability to effectively give themselves a massive health pool?

Why do members of Congress in committee hearings ask witnesses the same question multiple times?

Strange Sign on Lab Door

What's the most convenient time of year in the USA to end the world?

If I delete my router's history can my ISP still provide it to my parents?

Tikzing a circled star

Can we use the stored gravitational potential energy of a building to produce power?

Can a person refuse a presidential pardon?

Slow moving projectiles from a hand-held weapon - how do they reach the target?



Caching different http-requests


C# small caching APIMemcached cachingChaining HTTP requests becoming unreadableClass that make asynchronous http requestsCaching using phpFastCacheProxying Socket.io requests and other HTTP requestsAngular 2 / rxjs chaining HTTP callsChaining 3 dependent HTTP request subscriptions one, which is pollingChanging http-requests conditionallyRXJS queue up multiple http requests and send when x conditions happens













1












$begingroup$


There have been multiple discussions on caching http-requests with RXJS. In this question/proposal I want to propose a custom rxjs-operator (non-pure) to provide caching:



const cacheHttp = (cacheKey: string, cacheStorage: any) => (source: Observable<any>) => {
if (!cacheStorage[cacheKey]) {
cacheStorage[cacheKey] = source.pipe(
shareReplay(1)
);
}
return cacheStorage[cacheKey];
};


This operator is not pure, as it modifies one of its arguments (cacheStorage).



This operator could be used like this:



public cachedItems = {};

public getDataForItem$(itemId: string) {
return this.http.get('/item/' + itemId).pipe(
cacheHttp(itemId, this.cachedItems),
shareReplay(1)
);
}


The client could then call this multiple times without causing superfluous http-requests:



// the following two subscriptions cause http-requests
this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));

// all further subscriptions would not cause any additional http-requests
this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));
this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));

// this subscription would again cause an http-request:
this.itemService.getDataForItem('thirdItem').subscribe((val) => console.log(val));


Is this an acceptable approach to solving the "cache-for-different-requests-problem"? Is there possibly a memory-leak or are there any leaked subscriptions? Is it ok to have side-effects on a provided argument?










share|improve this question











$endgroup$

















    1












    $begingroup$


    There have been multiple discussions on caching http-requests with RXJS. In this question/proposal I want to propose a custom rxjs-operator (non-pure) to provide caching:



    const cacheHttp = (cacheKey: string, cacheStorage: any) => (source: Observable<any>) => {
    if (!cacheStorage[cacheKey]) {
    cacheStorage[cacheKey] = source.pipe(
    shareReplay(1)
    );
    }
    return cacheStorage[cacheKey];
    };


    This operator is not pure, as it modifies one of its arguments (cacheStorage).



    This operator could be used like this:



    public cachedItems = {};

    public getDataForItem$(itemId: string) {
    return this.http.get('/item/' + itemId).pipe(
    cacheHttp(itemId, this.cachedItems),
    shareReplay(1)
    );
    }


    The client could then call this multiple times without causing superfluous http-requests:



    // the following two subscriptions cause http-requests
    this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
    this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));

    // all further subscriptions would not cause any additional http-requests
    this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
    this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));
    this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
    this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));

    // this subscription would again cause an http-request:
    this.itemService.getDataForItem('thirdItem').subscribe((val) => console.log(val));


    Is this an acceptable approach to solving the "cache-for-different-requests-problem"? Is there possibly a memory-leak or are there any leaked subscriptions? Is it ok to have side-effects on a provided argument?










    share|improve this question











    $endgroup$















      1












      1








      1





      $begingroup$


      There have been multiple discussions on caching http-requests with RXJS. In this question/proposal I want to propose a custom rxjs-operator (non-pure) to provide caching:



      const cacheHttp = (cacheKey: string, cacheStorage: any) => (source: Observable<any>) => {
      if (!cacheStorage[cacheKey]) {
      cacheStorage[cacheKey] = source.pipe(
      shareReplay(1)
      );
      }
      return cacheStorage[cacheKey];
      };


      This operator is not pure, as it modifies one of its arguments (cacheStorage).



      This operator could be used like this:



      public cachedItems = {};

      public getDataForItem$(itemId: string) {
      return this.http.get('/item/' + itemId).pipe(
      cacheHttp(itemId, this.cachedItems),
      shareReplay(1)
      );
      }


      The client could then call this multiple times without causing superfluous http-requests:



      // the following two subscriptions cause http-requests
      this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
      this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));

      // all further subscriptions would not cause any additional http-requests
      this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
      this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));
      this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
      this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));

      // this subscription would again cause an http-request:
      this.itemService.getDataForItem('thirdItem').subscribe((val) => console.log(val));


      Is this an acceptable approach to solving the "cache-for-different-requests-problem"? Is there possibly a memory-leak or are there any leaked subscriptions? Is it ok to have side-effects on a provided argument?










      share|improve this question











      $endgroup$




      There have been multiple discussions on caching http-requests with RXJS. In this question/proposal I want to propose a custom rxjs-operator (non-pure) to provide caching:



      const cacheHttp = (cacheKey: string, cacheStorage: any) => (source: Observable<any>) => {
      if (!cacheStorage[cacheKey]) {
      cacheStorage[cacheKey] = source.pipe(
      shareReplay(1)
      );
      }
      return cacheStorage[cacheKey];
      };


      This operator is not pure, as it modifies one of its arguments (cacheStorage).



      This operator could be used like this:



      public cachedItems = {};

      public getDataForItem$(itemId: string) {
      return this.http.get('/item/' + itemId).pipe(
      cacheHttp(itemId, this.cachedItems),
      shareReplay(1)
      );
      }


      The client could then call this multiple times without causing superfluous http-requests:



      // the following two subscriptions cause http-requests
      this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
      this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));

      // all further subscriptions would not cause any additional http-requests
      this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
      this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));
      this.itemService.getDataForItem('firstItem').subscribe((val) => console.log(val));
      this.itemService.getDataForItem('secondItem').subscribe((val) => console.log(val));

      // this subscription would again cause an http-request:
      this.itemService.getDataForItem('thirdItem').subscribe((val) => console.log(val));


      Is this an acceptable approach to solving the "cache-for-different-requests-problem"? Is there possibly a memory-leak or are there any leaked subscriptions? Is it ok to have side-effects on a provided argument?







      javascript cache angular-2+ rxjs






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 34 mins ago









      Jamal

      30.3k11119227




      30.3k11119227










      asked Feb 4 at 15:51









      Tobias GassmannTobias Gassmann

      1061




      1061






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212854%2fcaching-different-http-requests%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212854%2fcaching-different-http-requests%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Webac Holding Inhaltsverzeichnis Geschichte | Organisationsstruktur | Tochterfirmen |...

          What's the meaning of a knight fighting a snail in medieval book illustrations?What is the meaning of a glove...

          Salamanca Inhaltsverzeichnis Lage und Klima | Bevölkerungsentwicklung | Geschichte | Kultur und...