How can this code which turns hourly data for columns of data into daily be improved? The 2019...

Identify 80s or 90s comics with ripped creatures (not dwarves)

Could an empire control the whole planet with today's comunication methods?

How do spell lists change if the party levels up without taking a long rest?

What was the last x86 CPU that did not have the x87 floating-point unit built in?

What information about me do stores get via my credit card?

How to read αἱμύλιος or when to aspirate

how can a perfect fourth interval be considered either consonant or dissonant?

How to handle characters who are more educated than the author?

Does Parliament hold absolute power in the UK?

How to politely respond to generic emails requesting a PhD/job in my lab? Without wasting too much time

Single author papers against my advisor's will?

Student Loan from years ago pops up and is taking my salary

Store Dynamic-accessible hidden metadata in a cell

Do warforged have souls?

How do you keep chess fun when your opponent constantly beats you?

What does Linus Torvalds mean when he says that Git "never ever" tracks a file?

"... to apply for a visa" or "... and applied for a visa"?

What do I do when my TA workload is more than expected?

Did the new image of black hole confirm the general theory of relativity?

The following signatures were invalid: EXPKEYSIG 1397BC53640DB551

Is this wall load bearing? Blueprints and photos attached

Deal with toxic manager when you can't quit

How to support a colleague who finds meetings extremely tiring?

Did the UK government pay "millions and millions of dollars" to try to snag Julian Assange?



How can this code which turns hourly data for columns of data into daily be improved?



The 2019 Stack Overflow Developer Survey Results Are In
Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Non-standardised data across multiple worksheets: Aggregation, Validation, FilteringVBA macro which filters and splits dataset into new workbooksForecast maintenance interval for fleet of aircraftConsolidate used student hours into master sheet for exportWorkbook for tracking projectsMaking a report from payroll detailsSum hours worked depending on day typeExcel 'big' data processing with vlookupsExcel 'Big' Data Processing FollowupFastest method of getting the bounding box containing all value ranges





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







0












$begingroup$


Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data



u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1

Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double


ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double

ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double

counter = 0
total_obs_q = 0

For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s

total_obs_q = total_obs_q + obs_q_d(w)

Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w








share







New contributor




Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$



















    0












    $begingroup$


    Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data



    u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
    t = Int((n - 1) / 24) + 1

    Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
    Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double


    ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double

    ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double

    counter = 0
    total_obs_q = 0

    For w = 1 To t
    rain_d(0) = 0
    evap_d(0) = 0
    obs_q_d(0) = 0
    sim_q_d(0) = 0
    For s = 0 To 23
    rain_recalc(w, s) = rainfall(counter)
    rain_d(w) = rain_d(w) + rain_recalc(w, s)
    evap_recalc(w, s) = evaporation(counter)
    evap_d(w) = evap_d(w) + evap_recalc(w, s)
    obs_q_recalc(w, s) = obs_q(counter)
    obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
    sim_q_recalc(w, s) = simulated_q(counter)
    sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
    counter = counter + 1
    Next s

    total_obs_q = total_obs_q + obs_q_d(w)

    Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
    Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
    Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
    Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
    Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
    Next w








    share







    New contributor




    Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data



      u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
      t = Int((n - 1) / 24) + 1

      Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
      Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double


      ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double

      ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double

      counter = 0
      total_obs_q = 0

      For w = 1 To t
      rain_d(0) = 0
      evap_d(0) = 0
      obs_q_d(0) = 0
      sim_q_d(0) = 0
      For s = 0 To 23
      rain_recalc(w, s) = rainfall(counter)
      rain_d(w) = rain_d(w) + rain_recalc(w, s)
      evap_recalc(w, s) = evaporation(counter)
      evap_d(w) = evap_d(w) + evap_recalc(w, s)
      obs_q_recalc(w, s) = obs_q(counter)
      obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
      sim_q_recalc(w, s) = simulated_q(counter)
      sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
      counter = counter + 1
      Next s

      total_obs_q = total_obs_q + obs_q_d(w)

      Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
      Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
      Next w








      share







      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data



      u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
      t = Int((n - 1) / 24) + 1

      Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
      Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double


      ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double

      ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double

      counter = 0
      total_obs_q = 0

      For w = 1 To t
      rain_d(0) = 0
      evap_d(0) = 0
      obs_q_d(0) = 0
      sim_q_d(0) = 0
      For s = 0 To 23
      rain_recalc(w, s) = rainfall(counter)
      rain_d(w) = rain_d(w) + rain_recalc(w, s)
      evap_recalc(w, s) = evaporation(counter)
      evap_d(w) = evap_d(w) + evap_recalc(w, s)
      obs_q_recalc(w, s) = obs_q(counter)
      obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
      sim_q_recalc(w, s) = simulated_q(counter)
      sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
      counter = counter + 1
      Next s

      total_obs_q = total_obs_q + obs_q_d(w)

      Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
      Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
      Next w






      vba excel





      share







      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 4 mins ago









      Josh AltonJosh Alton

      1




      1




      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes












          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217352%2fhow-can-this-code-which-turns-hourly-data-for-columns-of-data-into-daily-be-impr%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.













          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.












          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217352%2fhow-can-this-code-which-turns-hourly-data-for-columns-of-data-into-daily-be-impr%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Webac Holding Inhaltsverzeichnis Geschichte | Organisationsstruktur | Tochterfirmen |...

          What's the meaning of a knight fighting a snail in medieval book illustrations?What is the meaning of a glove...

          Salamanca Inhaltsverzeichnis Lage und Klima | Bevölkerungsentwicklung | Geschichte | Kultur und...