Simple java pattern matching (google interview)

What exactly is the meaning of "fine wine"?

Use Mercury as quenching liquid for swords?

Paper published similar to PhD thesis

Is this Paypal Github SDK reference really a dangerous site?

std::string vs const std::string& vs std::string_view

Help! My Character is too much for her story!

How to recover against Snake as a heavyweight character?

How would an energy-based "projectile" blow up a spaceship?

Finding integer solution to a quadratic equation in two unknowns

Is there a math expression equivalent to the conditional ternary operator?

A running toilet that stops itself

Tool for measuring readability of English text

Multi wire circuit or 2 separate 120V 20A dedicated circuits?

Trigger on Custom Object Share

Should I apply for my boss's promotion?

Is it a Cyclops number? "Nobody" knows!

Why isn't P and P/poly trivially the same?

Why do we call complex numbers “numbers” but we don’t consider 2-vectors numbers?

Is it appropriate to ask a former professor to order a library book for me through ILL?

What does it take to become a wilderness skills guide as a business?

Did Amazon pay $0 in taxes last year?

What does *dead* mean in *What do you mean, dead?*?

Has a sovereign Communist government ever run, and conceded loss, on a fair election?

Giving a talk in my old university, how prominently should I tell students my salary?



Simple java pattern matching (google interview)














0












$begingroup$


The interview question is: Write a function isMatch (without using java.util.Regex) that takes two strings as arguments: s (a string to match) and p (a regular expression pattern) and returns a boolean denoting whether s matches p. p can be composed of alphabetic characters, and '*' (denoting that the previous character matches 0 or more times).



This is what I tried, are there any bugs, or how could it be improved?



    private boolean isNextCharStarred(String s) {
return s.length() >= 2 && s.charAt(1) == '*';
}

private boolean recIsMatch(String s, String p, boolean hasPatternBeenEaten) {
if (p.length() == 0) {
return true;
}
if (s.length() == 0) {
if (isNextCharStarred(p)) {
return recIsMatch(s, p.substring(2), true);
}
return p.length() == 0;
}
if (isNextCharStarred(p)) {
if (s.charAt(0) != p.charAt(0)) {
return recIsMatch(s, p.substring(2), true);
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten)
|| recIsMatch(s, p.substring(2), true);
}
if (s.charAt(0) == p.charAt(0)) {
return recIsMatch(s.substring(1), p.substring(1), true);
}
if (hasPatternBeenEaten) {
return false;
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten);
}

public boolean isMatch(String s, String p) {
return recIsMatch(s, p, false);
}


}









share







New contributor




MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    The interview question is: Write a function isMatch (without using java.util.Regex) that takes two strings as arguments: s (a string to match) and p (a regular expression pattern) and returns a boolean denoting whether s matches p. p can be composed of alphabetic characters, and '*' (denoting that the previous character matches 0 or more times).



    This is what I tried, are there any bugs, or how could it be improved?



        private boolean isNextCharStarred(String s) {
    return s.length() >= 2 && s.charAt(1) == '*';
    }

    private boolean recIsMatch(String s, String p, boolean hasPatternBeenEaten) {
    if (p.length() == 0) {
    return true;
    }
    if (s.length() == 0) {
    if (isNextCharStarred(p)) {
    return recIsMatch(s, p.substring(2), true);
    }
    return p.length() == 0;
    }
    if (isNextCharStarred(p)) {
    if (s.charAt(0) != p.charAt(0)) {
    return recIsMatch(s, p.substring(2), true);
    }
    return recIsMatch(s.substring(1), p, hasPatternBeenEaten)
    || recIsMatch(s, p.substring(2), true);
    }
    if (s.charAt(0) == p.charAt(0)) {
    return recIsMatch(s.substring(1), p.substring(1), true);
    }
    if (hasPatternBeenEaten) {
    return false;
    }
    return recIsMatch(s.substring(1), p, hasPatternBeenEaten);
    }

    public boolean isMatch(String s, String p) {
    return recIsMatch(s, p, false);
    }


    }









    share







    New contributor




    MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      The interview question is: Write a function isMatch (without using java.util.Regex) that takes two strings as arguments: s (a string to match) and p (a regular expression pattern) and returns a boolean denoting whether s matches p. p can be composed of alphabetic characters, and '*' (denoting that the previous character matches 0 or more times).



      This is what I tried, are there any bugs, or how could it be improved?



          private boolean isNextCharStarred(String s) {
      return s.length() >= 2 && s.charAt(1) == '*';
      }

      private boolean recIsMatch(String s, String p, boolean hasPatternBeenEaten) {
      if (p.length() == 0) {
      return true;
      }
      if (s.length() == 0) {
      if (isNextCharStarred(p)) {
      return recIsMatch(s, p.substring(2), true);
      }
      return p.length() == 0;
      }
      if (isNextCharStarred(p)) {
      if (s.charAt(0) != p.charAt(0)) {
      return recIsMatch(s, p.substring(2), true);
      }
      return recIsMatch(s.substring(1), p, hasPatternBeenEaten)
      || recIsMatch(s, p.substring(2), true);
      }
      if (s.charAt(0) == p.charAt(0)) {
      return recIsMatch(s.substring(1), p.substring(1), true);
      }
      if (hasPatternBeenEaten) {
      return false;
      }
      return recIsMatch(s.substring(1), p, hasPatternBeenEaten);
      }

      public boolean isMatch(String s, String p) {
      return recIsMatch(s, p, false);
      }


      }









      share







      New contributor




      MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      The interview question is: Write a function isMatch (without using java.util.Regex) that takes two strings as arguments: s (a string to match) and p (a regular expression pattern) and returns a boolean denoting whether s matches p. p can be composed of alphabetic characters, and '*' (denoting that the previous character matches 0 or more times).



      This is what I tried, are there any bugs, or how could it be improved?



          private boolean isNextCharStarred(String s) {
      return s.length() >= 2 && s.charAt(1) == '*';
      }

      private boolean recIsMatch(String s, String p, boolean hasPatternBeenEaten) {
      if (p.length() == 0) {
      return true;
      }
      if (s.length() == 0) {
      if (isNextCharStarred(p)) {
      return recIsMatch(s, p.substring(2), true);
      }
      return p.length() == 0;
      }
      if (isNextCharStarred(p)) {
      if (s.charAt(0) != p.charAt(0)) {
      return recIsMatch(s, p.substring(2), true);
      }
      return recIsMatch(s.substring(1), p, hasPatternBeenEaten)
      || recIsMatch(s, p.substring(2), true);
      }
      if (s.charAt(0) == p.charAt(0)) {
      return recIsMatch(s.substring(1), p.substring(1), true);
      }
      if (hasPatternBeenEaten) {
      return false;
      }
      return recIsMatch(s.substring(1), p, hasPatternBeenEaten);
      }

      public boolean isMatch(String s, String p) {
      return recIsMatch(s, p, false);
      }


      }







      java regex





      share







      New contributor




      MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 2 mins ago









      MFXMFX

      1




      1




      New contributor




      MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          MFX is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215067%2fsimple-java-pattern-matching-google-interview%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          MFX is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          MFX is a new contributor. Be nice, and check out our Code of Conduct.













          MFX is a new contributor. Be nice, and check out our Code of Conduct.












          MFX is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215067%2fsimple-java-pattern-matching-google-interview%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Webac Holding Inhaltsverzeichnis Geschichte | Organisationsstruktur | Tochterfirmen |...

          What's the meaning of a knight fighting a snail in medieval book illustrations?What is the meaning of a glove...

          Salamanca Inhaltsverzeichnis Lage und Klima | Bevölkerungsentwicklung | Geschichte | Kultur und...