Is there a cleanest/less repetitive way to write this function?Is there a better way to write this jQuery UI...

Don't know what I’m looking for regarding removable HDDs?

How do I deal with being jealous of my own players?

A bug in Excel? Conditional formatting for marking duplicates also highlights unique value

How can I be pwned if I'm not registered on the compromised site?

Plagiarism of code by other PhD student

How to kill a localhost:8080

Sometimes a banana is just a banana

Every subset equal to original set?

What does @RC mean in SSDT SQL Server Unit Testing?

When was drinking water recognized as crucial in marathon running?

How to lift/raise/repair a segment of concrete slab?

Roots of 6th chords on the guitar for different inversions/voicings

Is divide-by-zero a security vulnerability?

For a 1-action spell, do I need to take a turn to ready the spell before I can cast it, or can I cast it immediately?

Borrowing Characters

Giving a talk in my old university, how prominently should I tell students my salary?

Why I cant see italic font at the header?

lead or lag function to get several values, not just the nth

What is better: yes / no radio, or simple checkbox?

At what level can a party fight a mimic?

Did Amazon pay $0 in taxes last year?

Is the withholding of funding notice allowed?

Is there a frame of reference in which I was born before I was conceived?

How to mitigate "bandwagon attacking" from players?



Is there a cleanest/less repetitive way to write this function?


Is there a better way to write this jQuery UI effect animation?Is there a “code less” way to construct this JS loop?Better way to write 'bulky' function in jQueryThe Handy-Dandy Apocalypse AssistantHow could I write this function in ES6/ES7?Condense repetitive jQuery .click functionPopup classes hierarchy designIs there a better way to write insertion sort?Is there a better way to sort this items?Material UI menu drop down component













0












$begingroup$


It's a user alert script. It worked in every browser I tested. But the function itself looks very messy/repetitive. Is there any way to make this cleaner?



function message(text) {
var alert = document.createElement('div');
var alertText = document.createTextNode(text);
var alertCloseButton = document.createElement('i');
var buttonText = document.createTextNode('close');
var shadow = document.createElement('div');

alert.className = 'alert-text';
alertCloseButton.className = 'material-icons';
alertCloseButton.id = 'close-alert';
alertCloseButton.setAttribute('onclick', 'function() { var a = this.parentNode; var s = a.parentNode; s.parentNode.removeChild(s)}');
alertCloseButton.onclick = function() { var a = this.parentNode; var s = a.parentNode; s.parentNode.removeChild(s) };
alertCloseButton.appendChild(buttonText);
alert.appendChild(alertCloseButton);
alert.appendChild(alertText);
shadow.className = 'shadow';
shadow.appendChild(alert);

document.body.appendChild(shadow);
}
var button = document.querySelector('button');
button.addEventListener('click', function(){
message('Button clicked');
});


Here's the code working: https://jsfiddle.net/3aouyfz7/









share







New contributor




Anderson Montelo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    It's a user alert script. It worked in every browser I tested. But the function itself looks very messy/repetitive. Is there any way to make this cleaner?



    function message(text) {
    var alert = document.createElement('div');
    var alertText = document.createTextNode(text);
    var alertCloseButton = document.createElement('i');
    var buttonText = document.createTextNode('close');
    var shadow = document.createElement('div');

    alert.className = 'alert-text';
    alertCloseButton.className = 'material-icons';
    alertCloseButton.id = 'close-alert';
    alertCloseButton.setAttribute('onclick', 'function() { var a = this.parentNode; var s = a.parentNode; s.parentNode.removeChild(s)}');
    alertCloseButton.onclick = function() { var a = this.parentNode; var s = a.parentNode; s.parentNode.removeChild(s) };
    alertCloseButton.appendChild(buttonText);
    alert.appendChild(alertCloseButton);
    alert.appendChild(alertText);
    shadow.className = 'shadow';
    shadow.appendChild(alert);

    document.body.appendChild(shadow);
    }
    var button = document.querySelector('button');
    button.addEventListener('click', function(){
    message('Button clicked');
    });


    Here's the code working: https://jsfiddle.net/3aouyfz7/









    share







    New contributor




    Anderson Montelo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      It's a user alert script. It worked in every browser I tested. But the function itself looks very messy/repetitive. Is there any way to make this cleaner?



      function message(text) {
      var alert = document.createElement('div');
      var alertText = document.createTextNode(text);
      var alertCloseButton = document.createElement('i');
      var buttonText = document.createTextNode('close');
      var shadow = document.createElement('div');

      alert.className = 'alert-text';
      alertCloseButton.className = 'material-icons';
      alertCloseButton.id = 'close-alert';
      alertCloseButton.setAttribute('onclick', 'function() { var a = this.parentNode; var s = a.parentNode; s.parentNode.removeChild(s)}');
      alertCloseButton.onclick = function() { var a = this.parentNode; var s = a.parentNode; s.parentNode.removeChild(s) };
      alertCloseButton.appendChild(buttonText);
      alert.appendChild(alertCloseButton);
      alert.appendChild(alertText);
      shadow.className = 'shadow';
      shadow.appendChild(alert);

      document.body.appendChild(shadow);
      }
      var button = document.querySelector('button');
      button.addEventListener('click', function(){
      message('Button clicked');
      });


      Here's the code working: https://jsfiddle.net/3aouyfz7/









      share







      New contributor




      Anderson Montelo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      It's a user alert script. It worked in every browser I tested. But the function itself looks very messy/repetitive. Is there any way to make this cleaner?



      function message(text) {
      var alert = document.createElement('div');
      var alertText = document.createTextNode(text);
      var alertCloseButton = document.createElement('i');
      var buttonText = document.createTextNode('close');
      var shadow = document.createElement('div');

      alert.className = 'alert-text';
      alertCloseButton.className = 'material-icons';
      alertCloseButton.id = 'close-alert';
      alertCloseButton.setAttribute('onclick', 'function() { var a = this.parentNode; var s = a.parentNode; s.parentNode.removeChild(s)}');
      alertCloseButton.onclick = function() { var a = this.parentNode; var s = a.parentNode; s.parentNode.removeChild(s) };
      alertCloseButton.appendChild(buttonText);
      alert.appendChild(alertCloseButton);
      alert.appendChild(alertText);
      shadow.className = 'shadow';
      shadow.appendChild(alert);

      document.body.appendChild(shadow);
      }
      var button = document.querySelector('button');
      button.addEventListener('click', function(){
      message('Button clicked');
      });


      Here's the code working: https://jsfiddle.net/3aouyfz7/







      javascript





      share







      New contributor




      Anderson Montelo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Anderson Montelo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Anderson Montelo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 1 min ago









      Anderson MonteloAnderson Montelo

      1




      1




      New contributor




      Anderson Montelo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Anderson Montelo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Anderson Montelo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Anderson Montelo is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214814%2fis-there-a-cleanest-less-repetitive-way-to-write-this-function%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Anderson Montelo is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Anderson Montelo is a new contributor. Be nice, and check out our Code of Conduct.













          Anderson Montelo is a new contributor. Be nice, and check out our Code of Conduct.












          Anderson Montelo is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214814%2fis-there-a-cleanest-less-repetitive-way-to-write-this-function%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Fairchild Swearingen Metro Inhaltsverzeichnis Geschichte | Innenausstattung | Nutzung | Zwischenfälle...

          Pilgersdorf Inhaltsverzeichnis Geografie | Geschichte | Bevölkerungsentwicklung | Politik | Kultur...

          Marineschifffahrtleitung Inhaltsverzeichnis Geschichte | Heutige Organisation der NATO | Nationale und...