Factory method pattern as type guard for classes with trait
Why can't we make a perpetual motion machine by using a magnet to pull up a piece of metal, then letting it fall back down?
I can't die. Who am I?
The need of reserving one's ability in job interviews
Misplaced tyre lever - alternatives?
Wrap all numerics in JSON with quotes
Why is it "take a leak?"
Sometimes a banana is just a banana
Called into a meeting and told we are being made redundant (laid off) and "not to share outside". Can I tell my partner?
Levi-Civita symbol: 3D matrix
Non-Italian European mafias in USA?
How can I create a Table like this in Latex?
How to mitigate "bandwagon attacking" from players?
Is there a frame of reference in which I was born before I was conceived?
What should the omniscient narrator call a character?
How can I be pwned if I'm not registered on the compromised site?
School performs periodic password audits. Is my password compromised?
Is there a full canon version of Tyrion's jackass/honeycomb joke?
It took me a lot of time to make this, pls like. (YouTube Comments #1)
Every subset equal to original set?
Can a space-faring robot still function over a billion years?
What is better: yes / no radio, or simple checkbox?
Are small insurances worth it
Is there a math equivalent to the conditional ternary operator?
Why do phishing e-mails use faked e-mail addresses instead of the real one?
Factory method pattern as type guard for classes with trait
$begingroup$
I want to accept an eloquent model with a trait in some method. I can't type hint it, so I created guard class with factory method and using it for type checking. Is there code smell?
class SearchableModel extends Model
{
use Searchable;
public static function from(Searchable $searchable) :IlluminateDatabaseEloquentModel
{
return $searchable;
}
}
public function someMethod(Searchable $model) {
$model = SearchableModel::from($model);
$model->search('term');
}
P.S. My motivation is using static analysis
laravel factory-method type-safety trait
asked 36 secs ago
matchishmatchish
1014
New contributor
matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I want to accept an eloquent model with a trait in some method. I can't type hint it, so I created guard class with factory method and using it for type checking. Is there code smell?
class SearchableModel extends Model
{
use Searchable;
public static function from(Searchable $searchable) :IlluminateDatabaseEloquentModel
{
return $searchable;
}
}
public function someMethod(Searchable $model) {
$model = SearchableModel::from($model);
$model->search('term');
}
P.S. My motivation is using static analysis
laravel factory-method type-safety trait
asked 36 secs ago
matchishmatchish
1014
New contributor
matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I want to accept an eloquent model with a trait in some method. I can't type hint it, so I created guard class with factory method and using it for type checking. Is there code smell?
class SearchableModel extends Model
{
use Searchable;
public static function from(Searchable $searchable) :IlluminateDatabaseEloquentModel
{
return $searchable;
}
}
public function someMethod(Searchable $model) {
$model = SearchableModel::from($model);
$model->search('term');
}
P.S. My motivation is using static analysis
laravel factory-method type-safety trait
asked 36 secs ago
matchishmatchish
1014
New contributor
matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I want to accept an eloquent model with a trait in some method. I can't type hint it, so I created guard class with factory method and using it for type checking. Is there code smell?
class SearchableModel extends Model
{
use Searchable;
public static function from(Searchable $searchable) :IlluminateDatabaseEloquentModel
{
return $searchable;
}
}
public function someMethod(Searchable $model) {
$model = SearchableModel::from($model);
$model->search('term');
}
P.S. My motivation is using static analysis
laravel factory-method type-safety trait
laravel factory-method type-safety trait
asked 36 secs ago
matchishmatchish
1014
New contributor
matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 36 secs ago
matchishmatchish
1014
New contributor
matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 36 secs ago
matchishmatchish
1014
New contributor
matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 36 secs ago
matchishmatchish
1014
asked 36 secs ago
matchishmatchish
1014
1014
New contributor
matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
matchish is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214815%2ffactory-method-pattern-as-type-guard-for-classes-with-trait%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
matchish is a new contributor. Be nice, and check out our Code of Conduct.
matchish is a new contributor. Be nice, and check out our Code of Conduct.
matchish is a new contributor. Be nice, and check out our Code of Conduct.
matchish is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214815%2ffactory-method-pattern-as-type-guard-for-classes-with-trait%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
