Ggthjy

Second-rate spelling

What could trigger powerful quakes on icy world?

Adding days to the Date portion of DateTime throws off the Time portion

Why do phishing e-mails use faked e-mail addresses instead of the real one?

I encountered my boss during an on-site interview at another company. Should I bring it up when seeing him next time?

It took me a lot of time to make this, pls like. (YouTube Comments #1)

Inverse of the covariance matrix of a multivariate normal distribution

In Adventurer's League, is it possible to keep the Ring of Winter if you manage to acquire it in the Tomb of Annihilation adventure?

How to kill a localhost:8080

Plagiarism of code by other PhD student

Get length of the longest sequence of numbers with the same sign

Book about a time-travel war fought by computers

Borrowing Characters

Why is working on the same position for more than 15 years not a red flag?

The need of reserving one's ability in job interviews

Skis versus snow shoes - when to choose which for travelling the backcountry?

Can I become debt free or should I file for bankruptcy? How do I manage my debt and finances?

VAT refund for a conference ticket in Sweden

lead or lag function to get several values, not just the nth

What are all the squawk codes?

Six real numbers so that product of any five is the sixth one

Where is the line between being obedient and getting bullied by a boss?

How to lift/raise/repair a segment of concrete slab?

A right or the right?

Implementing the MVC pattern properly in Tkinter

Comments on my Java pattern for Mutable turned Immutable objectsEF Code First with Repository, UnitOfWork and DbContextFactoryCorrect MVC pattern implementation for form validationIs this correct implementation of MVC pattern for PHP website?Following Repository Pattern properlyIs the following repository pattern properly applied?Implementation of MVC Bootstrap & FactoryMVC app to associate users with rolesHow to properly implement Tkinter module for software development?Implementation of MVC pattern for single and multiple objects

0

$begingroup$

I have written a very simple Tkinter program to convert km to miles: it consists of a text entry box, a button, and a text box to print the output to.

The model just does the multiplication, and the view sets out the layout of the three widgets.

I'm worried about the following code in my Controller class (the method is bound to the button):

def execute(self, event):

    km = self.view.e1_value.get()

    miles = self.model.km_to_miles(km)

    self.view.output(miles)

Question:

Is this following the MVC pattern, or am i mixing up GUI and "business" logic?

The repo is uploaded here: https://github.com/masumshaikh/UdemyPythonMegaCourse/tree/master/003%20Tkinter

instructor.py is the code that was presented in a lecture, which I have tried to translate to the MVC patter in km_to_miles.py.

design-patterns mvc tkinter

share|improve this question

edited 5 mins ago

butterflyknife

asked 26 mins ago

butterflyknifebutterflyknife

11

New contributor

butterflyknife is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

• 
  
  
  

  
  2
  

  
  
  
  
  
  

  
  $begingroup$
  Welcome to Code Review! As per the rules in the help center, the code to be reviewed must be embedded in the question itself. You may include a GitHub link as supplementary material.
  $endgroup$
  – 200_success
  13 mins ago
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  $begingroup$
  Also, please retitle the question to state the task accomplished by the code, rather than your primary concern about the code. See How to Ask.
  $endgroup$
  – 200_success
  13 mins ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  @200_success: thank you for the guidance. I hope the edits I just made have improved the question.
  $endgroup$
  – butterflyknife
  5 mins ago
  

  
  
  
  

add a comment | 

0

$begingroup$

I have written a very simple Tkinter program to convert km to miles: it consists of a text entry box, a button, and a text box to print the output to.

The model just does the multiplication, and the view sets out the layout of the three widgets.

I'm worried about the following code in my Controller class (the method is bound to the button):

def execute(self, event):

    km = self.view.e1_value.get()

    miles = self.model.km_to_miles(km)

    self.view.output(miles)

Question:

Is this following the MVC pattern, or am i mixing up GUI and "business" logic?

The repo is uploaded here: https://github.com/masumshaikh/UdemyPythonMegaCourse/tree/master/003%20Tkinter

instructor.py is the code that was presented in a lecture, which I have tried to translate to the MVC patter in km_to_miles.py.

design-patterns mvc tkinter

share|improve this question

edited 5 mins ago

butterflyknife

asked 26 mins ago

butterflyknifebutterflyknife

11

New contributor

butterflyknife is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

• 
  
  
  

  
  2
  

  
  
  
  
  
  

  
  $begingroup$
  Welcome to Code Review! As per the rules in the help center, the code to be reviewed must be embedded in the question itself. You may include a GitHub link as supplementary material.
  $endgroup$
  – 200_success
  13 mins ago
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  $begingroup$
  Also, please retitle the question to state the task accomplished by the code, rather than your primary concern about the code. See How to Ask.
  $endgroup$
  – 200_success
  13 mins ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  @200_success: thank you for the guidance. I hope the edits I just made have improved the question.
  $endgroup$
  – butterflyknife
  5 mins ago
  

  
  
  
  

add a comment | 

$begingroup$

I have written a very simple Tkinter program to convert km to miles: it consists of a text entry box, a button, and a text box to print the output to.

The model just does the multiplication, and the view sets out the layout of the three widgets.

I'm worried about the following code in my Controller class (the method is bound to the button):

def execute(self, event):

    km = self.view.e1_value.get()

    miles = self.model.km_to_miles(km)

    self.view.output(miles)

Question:

Is this following the MVC pattern, or am i mixing up GUI and "business" logic?

The repo is uploaded here: https://github.com/masumshaikh/UdemyPythonMegaCourse/tree/master/003%20Tkinter

instructor.py is the code that was presented in a lecture, which I have tried to translate to the MVC patter in km_to_miles.py.

design-patterns mvc tkinter

share|improve this question

edited 5 mins ago

butterflyknife

asked 26 mins ago

butterflyknifebutterflyknife

11

New contributor

butterflyknife is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

def execute(self, event):

    km = self.view.e1_value.get()

    miles = self.model.km_to_miles(km)

    self.view.output(miles)

share|improve this question

edited 5 mins ago

butterflyknife

asked 26 mins ago

butterflyknifebutterflyknife

11

New contributor

butterflyknife is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

share|improve this question

edited 5 mins ago

butterflyknife

asked 26 mins ago

butterflyknifebutterflyknife

11

New contributor

butterflyknife is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked 26 mins ago

butterflyknifebutterflyknife

11

New contributor

butterflyknife is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked 26 mins ago

butterflyknifebutterflyknife

11