Testing a Controller in a while loopUnit-testing a controller in Ruby on RailsUnit testing extension for...
A right or the right?
Misplaced tyre lever - alternatives?
Why is it "take a leak?"
Is the withholding of funding notice allowed?
Is there a math equivalent to the conditional ternary operator?
What does @RC mean in SSDT SQL Server Unit Testing?
Book about a time-travel war fought by computers
What are all the squawk codes?
lead or lag function to get several values, not just the nth
How to mitigate "bandwagon attacking" from players?
Did Amazon pay $0 in taxes last year?
Called into a meeting and told we are being made redundant (laid off) and "not to share outside". Can I tell my partner?
What is this waxed root vegetable?
What are the issues with an additional (limited) concentration slot instead of Bladesong?
Can throughput exceed the bandwidth of a network
How to evaluate the limit where something is raised to a power of x?
Rationale to prefer local variables over instance variables?
Are there any other Chaos-worshipping races?
Citing contemporaneous (interlaced?) preprints
Toast materialize
How can atoms be electrically neutral when there is a difference in the positions of the charges?
I encountered my boss during an on-site interview at another company. Should I bring it up when seeing him next time?
Roots of chords on the guitar for different inversions/voicings
Is it possible to make a clamp function shorter than a ternary in JS?
Testing a Controller in a while loop
Unit-testing a controller in Ruby on RailsUnit testing extension for equality testingTesting a mixin functionUnit-testing an adapterRspec - testing basic functionality - redundant testing?Testing Out TestingPython unit testing for a Stack data structureTesting controller class using mockito mvcC# Unit Testing converterUnit Testing for Spring Controller
$begingroup$
I would like to see suggestions, if my code could be more improved. In my controller I have a line
self.bool_value = False # for testing
which in my opinion should not be there, because I put it there only for testing purposes, but I did not find any way around. In addition I would like to know, whether you guys test the init method as well, because I see no point in it. And another question would be, if you guys would test, if the parameter 'req' was called in the execute method. Any other suggestions to improve this code are welcomed.
My Controller looks like this:
from typing import Callable
from source.controller.RequestModel import RequestModel
from source.boundaries.AbstractInputBoundary import AbstractInputBoundary
class Controller:
abstractInputBoundary: AbstractInputBoundary
bool_function: Callable[[bool], bool]
bool_value: bool
def __init__(self, abstract_input_boundary, bool_function=lambda _: True):
self.abstractInputBoundary = abstract_input_boundary
self.bool_function = bool_function
self.bool_value = True
def process_input(self) -> None:
"""
Waits for the input of the User in order to call a usecase
:rtype: None
"""
while self.bool_function(self.bool_value):
self.bool_value = False # for testing
inp: str = input()
if inp == "show data":
req = RequestModel()
req.setRequest(inp)
self.abstractInputBoundary.execute(req)
My Test looks like the following:
import unittest
from source.controller.Controller import Controller
from unittest.mock import patch
from unittest.mock import MagicMock
class TestController(unittest.TestCase):
def test_process_input(self):
"""
This tests, whether after the input "show data" in the controller object a boundary object is called
"""
def switch_function(switch_bool):
if switch_bool is True:
return True
else:
return False
with patch('builtins.input') as inp:
inp.return_value = "show data"
boundary = MagicMock()
boundary.execute = MagicMock()
controller = Controller(boundary, switch_function)
controller.process_input()
assert boundary.execute.called
python-3.x unit-testing
asked 51 secs ago
davidh38davidh38
1
New contributor
davidh38 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I would like to see suggestions, if my code could be more improved. In my controller I have a line
self.bool_value = False # for testing
which in my opinion should not be there, because I put it there only for testing purposes, but I did not find any way around. In addition I would like to know, whether you guys test the init method as well, because I see no point in it. And another question would be, if you guys would test, if the parameter 'req' was called in the execute method. Any other suggestions to improve this code are welcomed.
My Controller looks like this:
from typing import Callable
from source.controller.RequestModel import RequestModel
from source.boundaries.AbstractInputBoundary import AbstractInputBoundary
class Controller:
abstractInputBoundary: AbstractInputBoundary
bool_function: Callable[[bool], bool]
bool_value: bool
def __init__(self, abstract_input_boundary, bool_function=lambda _: True):
self.abstractInputBoundary = abstract_input_boundary
self.bool_function = bool_function
self.bool_value = True
def process_input(self) -> None:
"""
Waits for the input of the User in order to call a usecase
:rtype: None
"""
while self.bool_function(self.bool_value):
self.bool_value = False # for testing
inp: str = input()
if inp == "show data":
req = RequestModel()
req.setRequest(inp)
self.abstractInputBoundary.execute(req)
My Test looks like the following:
import unittest
from source.controller.Controller import Controller
from unittest.mock import patch
from unittest.mock import MagicMock
class TestController(unittest.TestCase):
def test_process_input(self):
"""
This tests, whether after the input "show data" in the controller object a boundary object is called
"""
def switch_function(switch_bool):
if switch_bool is True:
return True
else:
return False
with patch('builtins.input') as inp:
inp.return_value = "show data"
boundary = MagicMock()
boundary.execute = MagicMock()
controller = Controller(boundary, switch_function)
controller.process_input()
assert boundary.execute.called
python-3.x unit-testing
asked 51 secs ago
davidh38davidh38
1
New contributor
davidh38 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I would like to see suggestions, if my code could be more improved. In my controller I have a line
self.bool_value = False # for testing
which in my opinion should not be there, because I put it there only for testing purposes, but I did not find any way around. In addition I would like to know, whether you guys test the init method as well, because I see no point in it. And another question would be, if you guys would test, if the parameter 'req' was called in the execute method. Any other suggestions to improve this code are welcomed.
My Controller looks like this:
from typing import Callable
from source.controller.RequestModel import RequestModel
from source.boundaries.AbstractInputBoundary import AbstractInputBoundary
class Controller:
abstractInputBoundary: AbstractInputBoundary
bool_function: Callable[[bool], bool]
bool_value: bool
def __init__(self, abstract_input_boundary, bool_function=lambda _: True):
self.abstractInputBoundary = abstract_input_boundary
self.bool_function = bool_function
self.bool_value = True
def process_input(self) -> None:
"""
Waits for the input of the User in order to call a usecase
:rtype: None
"""
while self.bool_function(self.bool_value):
self.bool_value = False # for testing
inp: str = input()
if inp == "show data":
req = RequestModel()
req.setRequest(inp)
self.abstractInputBoundary.execute(req)
My Test looks like the following:
import unittest
from source.controller.Controller import Controller
from unittest.mock import patch
from unittest.mock import MagicMock
class TestController(unittest.TestCase):
def test_process_input(self):
"""
This tests, whether after the input "show data" in the controller object a boundary object is called
"""
def switch_function(switch_bool):
if switch_bool is True:
return True
else:
return False
with patch('builtins.input') as inp:
inp.return_value = "show data"
boundary = MagicMock()
boundary.execute = MagicMock()
controller = Controller(boundary, switch_function)
controller.process_input()
assert boundary.execute.called
python-3.x unit-testing
asked 51 secs ago
davidh38davidh38
1
New contributor
davidh38 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I would like to see suggestions, if my code could be more improved. In my controller I have a line
self.bool_value = False # for testing
which in my opinion should not be there, because I put it there only for testing purposes, but I did not find any way around. In addition I would like to know, whether you guys test the init method as well, because I see no point in it. And another question would be, if you guys would test, if the parameter 'req' was called in the execute method. Any other suggestions to improve this code are welcomed.
My Controller looks like this:
from typing import Callable
from source.controller.RequestModel import RequestModel
from source.boundaries.AbstractInputBoundary import AbstractInputBoundary
class Controller:
abstractInputBoundary: AbstractInputBoundary
bool_function: Callable[[bool], bool]
bool_value: bool
def __init__(self, abstract_input_boundary, bool_function=lambda _: True):
self.abstractInputBoundary = abstract_input_boundary
self.bool_function = bool_function
self.bool_value = True
def process_input(self) -> None:
"""
Waits for the input of the User in order to call a usecase
:rtype: None
"""
while self.bool_function(self.bool_value):
self.bool_value = False # for testing
inp: str = input()
if inp == "show data":
req = RequestModel()
req.setRequest(inp)
self.abstractInputBoundary.execute(req)
My Test looks like the following:
import unittest
from source.controller.Controller import Controller
from unittest.mock import patch
from unittest.mock import MagicMock
class TestController(unittest.TestCase):
def test_process_input(self):
"""
This tests, whether after the input "show data" in the controller object a boundary object is called
"""
def switch_function(switch_bool):
if switch_bool is True:
return True
else:
return False
with patch('builtins.input') as inp:
inp.return_value = "show data"
boundary = MagicMock()
boundary.execute = MagicMock()
controller = Controller(boundary, switch_function)
controller.process_input()
assert boundary.execute.called
python-3.x unit-testing
python-3.x unit-testing
asked 51 secs ago
davidh38davidh38
1
New contributor
davidh38 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 51 secs ago
davidh38davidh38
1
New contributor
davidh38 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 51 secs ago
davidh38davidh38
1
New contributor
davidh38 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 51 secs ago
davidh38davidh38
1
asked 51 secs ago
davidh38davidh38
1
1
New contributor
davidh38 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
davidh38 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
davidh38 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
davidh38 is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214808%2ftesting-a-controller-in-a-while-loop%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
davidh38 is a new contributor. Be nice, and check out our Code of Conduct.
davidh38 is a new contributor. Be nice, and check out our Code of Conduct.
davidh38 is a new contributor. Be nice, and check out our Code of Conduct.
davidh38 is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214808%2ftesting-a-controller-in-a-while-loop%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
