Ggthjy

I'm using python 3.6 and I am trying to make a card game. I'm trying to make it display the winner of the game and move the two cards that have been played into a new "winners list" however I am pretty new to programming and I just can't seem to make the comparing car section work. The game should compare player 1 and player 2's cards and the winner should receive both cards. inicially the colour are compare d and if they are the same the value is compared. The colour parameters are listed in the code Any improvements I can make to improve my program and some help as for how to make it work would be greatly appreciated. specifically, they are of the program labelled: #definition of the rule and comparing the cards. it just endlessly print player 2 wins.

import itertools

import random

Winner = False

finished = False

vals = ['1','2', '3', '4', '5', '6', '7', '8', '9', '10']

suits = ['Yellows', 'Reds', 'Blacks']



deck = list(itertools.product(vals, suits))



random.shuffle(deck)



for val, suit in deck:

    print('%s of %s' % (val, suit))







player1card = deck[0:len(deck)//2]

player2card = deck[len(deck)//2:]

print("this is player 1",player1card)

print("this is Player 2 ",player2card)

#winning list

P1_Win = []

P2_Win = []

#still need to work on the scoring

player1_score = 0

player2_score = 0



while len(deck) > 0:



   if Winner == True:

        player1card[0].append(P1_Win)

        player2card[0].append(P1_win)

#definition of the rule and comparing the cards

   if player1card[0][1] == "Blacks" and player2card[0][1] == "Blacks":

        player1card[0][0] > player2card[0][0]

        print("Player 1 wins")



   if player1card[0][1] == "Reds" and player2card[0][1] == "Reds":

        player1card[0][0] > player2card[0][0]

        print("Player 1 wins")



   if player1card[0][1] == "Yellows" and player2card[0][1] == "Yellows":

        player1card[0][0] > player2card[0][0]

        print("Player 1 wins")



   if player1card[0][1] == "Blacks" and player2card[0][1] == "Yellow":

        Winner == True

        print("Player 1 wins")



   if player1card[0][1] == "Reds" and player2card[0][1] == "Blacks":

        Winner == True

        print("Player 1 wins")



   if player1card[0][1] == "Yellows" and player2card[0][1] == "Reds":

        Winner == True

        print("Player 1 wins")

   else:

        player1card.append(P2_Win)

        player2card.append(P2_Win)

        print("Player 2 wins")

You say that you want the winner of a hand to receive both cards played, and you have a "winning" list per player (P1_Win and P2_Win), but you're never actually adding cards to either of these lists. You use the .append method of player1card and player2card, with the winning lists as arguments, but this usage of .append appends P1_Win or P2_Win to the playerXcard list (and remember the PX_Win lists are empty since you don't have any code adding cards to them).

You're looping while the deck size is non-zero, but you're never pulling cards off of the deck. Furthermore, I'm guessing you want the game to be played while the players are holding cards, and that their personal decks are diminishing with each hand. If this is correct, then you'd want to loop while the sum of the number of each players cards is non-zero, or while both of them are non-zero. For example,

while len(player1card) != 0 and len(player2card) != 0:

In accordance with the above two points, when a hand has been played, you need to remove the cards from each players list of cards, and add the cards to the winners list. It would probably result in cleaner code if you removed the cards for the current hand up front, compared them more directly, and then added them the appropriate winning list. Here's a possibility,

while len(player1card) != 0 and len(player2card) != 0:

   # Pop the first card tuple off of each players deck.

   player1hand = player1card.pop(0)

   player2hand = player2card.pop(0)



   # ...potentially skipping into some of the comparison logic.

   # This compares the suits of each card first.

   if player1hand[1] == "Blacks" and player2hand[1] == "Blacks":

       # The values of the cards are compared second.

       player1hand[0] > player2hand[0]

       print("Player 1 wins")



   # Assuming player 1 wins, your code might look like the following.

   # You need to append each players card/hand to the winning list.

   P1_win.append(player1hand)

   P1_win.append(player2hand)

Also, you have a few cases where you've written Winner == True, which is comparing whether Winner is equal to True but I think you intended to set Winner equal to True (Winner = True).

There are some other things that could be discussed, but I think that should be enough to get you in the right direction.